Skip to content

DataLoader: don't wrap an already Encodable value in AnyEncodable #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kean merged 1 commit into from
Apr 25, 2024
Merged

DataLoader: don't wrap an already Encodable value in AnyEncodable #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Get/DataLoader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ func encode(_ value: Encodable, using encoder: JSONEncoder) async throws -> Data
return string.data(using: .utf8)
} else {
return try await Task.detached {
try encoder.encode(AnyEncodable(value: value))
try encoder.encode(value)
Copy link
Owner

@kean kean Apr 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think AnyEncodable can now also be removed. It was probably a rudiment from one of the earlier implementations or was required by one of the earlier Swift versions – I can't remember now.

Copy link
Contributor Author

@AndrewSB AndrewSB Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there might have been a time when AnyEncodable didn't support Optionals or something

Copy link
Contributor Author

@AndrewSB AndrewSB Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want me to remove and update this PR? or you want to do it?

Copy link
Owner

@kean kean Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate if you could remove it, but I can do it myself later.

Copy link
Owner

@kean kean Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it in main

}.value
}
}
Expand Down