Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LdapPool::get_connection fail more gracefully by returning Result #12

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Make LdapPool::get_connection fail more gracefully by returning Result #12

merged 1 commit into from
Apr 16, 2024

Conversation

aeveris
Copy link

@aeveris aeveris commented Apr 15, 2024 •
edited
Loading

This PR implements the following:

  • change LdapPool::get_connection to return Result so that errors can be handled by the caller.
  • add two additional variants to the crate's Error to represent connection and pool errors

Fixes #10

@keaz keaz self-requested a review April 16, 2024 11:15
keaz
keaz approved these changes Apr 16, 2024
View reviewed changes
Copy link
Owner

@keaz keaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keaz keaz merged commit ef4d8c4 into keaz:main Apr 16, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keaz keaz keaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LdapPool::get_connection may panic making error handling difficult
2 participants
@aeveris @keaz