-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor streaming_search_inner to return a Stream object #15
Merged
Merged
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e97f18c
Refactor streaming_search_inner to return a Stream object
keaz 94d41db
Bump version to 1.7.0 in Cargo.toml
keaz 931de5d
updated the README
keaz d881589
Implemented stream for stream_search
keaz 8175f35
Updated ReadME
keaz 66cdc07
Incoperated review comments
keaz c7961cd
Addressed review comments
keaz c9683e1
Updated ReadME
keaz 33a6b3e
Handled errors in cleanup methos
keaz d84c665
Fixed CI
keaz fc4a233
Fixed CI
keaz 908709b
Added Github CI status to README
keaz 20bda5d
Update ci.yml
keaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,84 +1,117 @@ | ||
version: 1 | ||
|
||
dn: dc=example,dc=com | ||
objectClass: domain | ||
objectClass: top | ||
objectClass: domain | ||
dc: example | ||
entryUUID: 724bddc1-a3d1-3d8d-b43c-ae7f3fa6954f | ||
|
||
dn: ou=people,dc=example,dc=com | ||
objectClass: organizationalUnit | ||
objectClass: top | ||
objectClass: organizationalUnit | ||
ou: people | ||
description: Users | ||
|
||
entryUUID: eb8f50dc-6283-3541-a1b3-d0ac3cae9e28 | ||
|
||
dn: uid=f92f4cb2-e821-44a4-bb13-b8ebadf4ecc5,ou=people,dc=example,dc=com | ||
objectClass: top | ||
objectClass: inetorgperson | ||
objectClass: organizationalPerson | ||
objectClass: person | ||
objectClass: top | ||
cn: Sam | ||
sn: Smith | ||
cn: Sam | ||
ou: people | ||
uid: f92f4cb2-e821-44a4-bb13-b8ebadf4ecc5 | ||
entryUUID: d03a2650-afae-3e43-8fe6-3df3b486a8f9 | ||
|
||
dn: uid=42b05942-4f18-4279-827d-36534da1e437,ou=people,dc=example,dc=com | ||
objectClass: top | ||
objectClass: inetorgperson | ||
objectClass: organizationalPerson | ||
objectClass: person | ||
objectClass: top | ||
cn: James | ||
sn: Gunn | ||
cn: James | ||
ou: people | ||
uid: 42b05942-4f18-4279-827d-36534da1e437 | ||
entryUUID: b34503f5-c572-302c-a135-4f78665f0032 | ||
|
||
dn: uid=0dbaece8-f5f8-4e85-97d8-8bd614304bef,ou=people,dc=example,dc=com | ||
objectClass: top | ||
objectClass: inetorgperson | ||
objectClass: organizationalPerson | ||
objectClass: person | ||
objectClass: top | ||
cn: James | ||
sn: Gunn | ||
cn: James | ||
ou: people | ||
uid: 0dbaece8-f5f8-4e85-97d8-8bd614304bef | ||
entryUUID: cb0bafca-46aa-3db4-9c3c-abab3a273a70 | ||
|
||
dn: uid=0xbaece8-f5f8-4e85-97d8-8bd614304bef,ou=people,dc=example,dc=com | ||
objectClass: top | ||
objectClass: inetorgperson | ||
objectClass: organizationalPerson | ||
objectClass: person | ||
objectClass: top | ||
cn: James | ||
sn: Gunn | ||
cn: James | ||
ou: people | ||
uid: 0xbaece8-f5f8-4e85-97d8-8bd614304bef | ||
entryUUID: 352b9f11-3394-3bf1-857b-9d4df00bb4a4 | ||
|
||
dn: uid=e219fbc0-6df5-4bc3-a6ee-986843bb157e,ou=people,dc=example,dc=com | ||
objectClass: top | ||
objectClass: inetorgperson | ||
objectClass: organizationalPerson | ||
objectClass: person | ||
objectClass: top | ||
cn: Jhone | ||
sn: Eliet | ||
cn: Jhone | ||
ou: people | ||
uid: e219fbc0-6df5-4bc3-a6ee-986843bb157e | ||
entryUUID: 158464c3-f19b-388d-856a-4bed06c24dcb | ||
|
||
dn: uid=cb4bc91e-21d8-4bcc-bf6a-317b84c2e58b,ou=people,dc=example,dc=com | ||
objectClass: top | ||
objectClass: inetorgperson | ||
objectClass: organizationalPerson | ||
objectClass: person | ||
objectClass: top | ||
cn: David | ||
sn: Hanks | ||
cn: David | ||
ou: people | ||
uid: cb4bc91e-21d8-4bcc-bf6a-317b84c2e58b | ||
entryUUID: 82b49fc0-c700-3b64-881a-7a9fb315ba85 | ||
|
||
dn: uid=4d9b08fe-9a14-4df0-9831-ea9992837f0d,ou=people,dc=example,dc=com | ||
objectClass: top | ||
objectClass: inetorgperson | ||
objectClass: organizationalPerson | ||
objectClass: person | ||
objectClass: top | ||
cn: David | ||
sn: Hanks | ||
cn: David | ||
ou: people | ||
uid: 4d9b08fe-9a14-4df0-9831-ea9992837f0d | ||
entryUUID: 7036d8ba-8170-31d5-9f7f-38e11f63d13f | ||
|
||
dn: ou=group,dc=example,dc=com | ||
objectClass: top | ||
objectClass: organizationalUnit | ||
ou: group | ||
description: Groups | ||
createTimestamp: 20241011170327Z | ||
creatorsName: cn=Directory Manager,cn=Root DNs,cn=config | ||
entryUUID: 68d83ad5-29d5-4505-a58c-1ef19121683a | ||
|
||
dn: cn=grp1,ou=group,dc=example,dc=com | ||
objectClass: top | ||
objectClass: groupOfNames | ||
cn: grp1 | ||
member: uid=e219fbc0-6df5-4bc3-a6ee-986843bb157e,ou=people,dc=example,dc=com | ||
createTimestamp: 20241011170342Z | ||
creatorsName: cn=Directory Manager,cn=Root DNs,cn=config | ||
entryUUID: 4618dc11-b54c-4db7-97f2-da09a33112e7 | ||
|
||
dn: cn=grp2,ou=group,dc=example,dc=com | ||
objectClass: top | ||
objectClass: groupOfNames | ||
cn: grp2 | ||
member: uid=e219fbc0-6df5-4bc3-a6ee-986843bb157e,ou=people,dc=example,dc=com | ||
createTimestamp: 20241011170356Z | ||
creatorsName: cn=Directory Manager,cn=Root DNs,cn=config | ||
entryUUID: 415d5386-3812-499c-a951-9a5945400ff8 | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the return type of a function warrants a major version bump.
PS. cargo-semver-checks is a pretty neat semver linter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bumped major version