Skip to content

Commit

Permalink
Merge pull request #425 from keboola/odin-container-id-fix
Browse files Browse the repository at this point in the history
fix: container id/name generation
  • Loading branch information
odinuv authored May 11, 2019
2 parents 3f241bf + fd72a9c commit 38700b1
Showing 1 changed file with 13 additions and 10 deletions.
23 changes: 13 additions & 10 deletions src/Docker/Runner.php
Original file line number Diff line number Diff line change
Expand Up @@ -472,16 +472,19 @@ private function runImages($jobId, $configId, $rowId, Component $component, Usag
];
$configFile->createConfigFile($image->getConfigData(), $outputFilter);

$containerIdParts[] = $jobId;
$containerIdParts[] = $this->storageClient->getRunId() ?: 'norunid';
$containerIdParts[] = $rowId;
$containerIdParts[] = $priority;
$containerIdParts[] = $image->getSourceComponent()->getSanitizedComponentId();

$containerNameParts[] = $image->getSourceComponent()->getSanitizedComponentId();
$containerNameParts[] = $jobId;
$containerNameParts[] = $this->storageClient->getRunId() ?: 'norunid';
$containerNameParts[] = $priority;
$containerIdParts = [
$jobId,
$this->storageClient->getRunId() ?: 'norunid',
$rowId,
$priority,
$image->getSourceComponent()->getSanitizedComponentId()
];
$containerNameParts = [
$image->getSourceComponent()->getSanitizedComponentId(),
$jobId,
$this->storageClient->getRunId() ?: 'norunid',
$priority,
];

$container = $this->createContainerFromImage(
$image,
Expand Down

0 comments on commit 38700b1

Please sign in to comment.