Conversation
Matovidlo
force-pushed
the
KAB-1030-add-mcp-server-event-schema
branch
from
0288d05 to
ad887d0
Compare
Matovidlo
requested review from
a team and
romanbracinik
and removed request for
a team
romanbracinik
left a comment
romanbracinik
left a comment
There was a problem hiding this comment.
uplne neviem o co sa jedna neslo by prehodt review na niekoho kto do toho vidi viac?
Matovidlo
force-pushed
the
KAB-1030-add-mcp-server-event-schema
branch
2 times, most recently
from
cff154f to
475dccc
Compare
|
@romanbracinik zatial by sme to mali deployed na canary-orion, potom by sme to chceli dat do produkcie. Jedna sa o eventy pre MCP server podobne ako existuju v tomto repe CLI eventy (pull,push etc.) |
|
@vita-stejskal I added the sessionID here 696af82 to mcp-server-context for user tool execution tracking |
@Matovidlo Skor mi ide o nejake zadanie alebo nieco podla coho dokazem zvalidovat, ze tento PR je OK |
|
@romanbracinik nalinkoval som jira tasky do description, je tam popis na to ze potrebujeme "merat" tool calling, MCP context uzivatela odkial ide (lokalna, remote instancia), nazov a argumenty toolu |
romanbracinik
left a comment
romanbracinik
left a comment
There was a problem hiding this comment.
Presiel som to a par veci mi neni uplne jasnych
It should track usage of various tools within projects. fix: Remove query and projectID, add MCP server context Update schema test acordingly fix: Rename file to cotains only one dot before extension Reason: configurationId is not needed for this component fix: Change tool arguments to be key value pair fix: Rename keboola.mcp-server to keboola.mcp-server.tool, remove jobID Reason: We expect to measure prompts and resources and we will have multiple schemas for the component. Remove jobID as it is required only by 1 tool fix: Update tests based on req changes for jobID, key value arguments
Reason: we are tracking sessions of users in which some of the MCP tool calls have not been/have been working
Reason: the error will be indicated by `type` and `message` fields
Matovidlo
force-pushed
the
KAB-1030-add-mcp-server-event-schema
branch
from
b2e7856 to
a9f2339
Compare
|
Would it be useful to also collect the MCP "transport" type (e.g. |
5 participants
Before asking for review make sure that:
you created a task for KBC team to update event-schema in Connection (validation in API endpoint)
you notified everyone in #general that even schema is changing
Event schema for MCP server should track usage of various tools exeuction by MCP server/client within keboola projects.
https://keboola.atlassian.net/browse/AI-1189
https://keboola.atlassian.net/browse/AI-1191
https://keboola.atlassian.net/browse/AI-1190