Skip to content

Comments

feat: Add RO chat event schema#30

Merged
Matovidlo merged 1 commit intomainfrom
feat-add-ro-chat-event
Oct 17, 2025
Merged

feat: Add RO chat event schema#30
Matovidlo merged 1 commit intomainfrom
feat-add-ro-chat-event

Conversation

@Matovidlo
Copy link
Contributor

@Matovidlo Matovidlo commented Oct 16, 2025

Before asking for review make sure that:

@Matovidlo Matovidlo changed the base branch from main to bc-remove-old-mcp-schema October 16, 2025 08:59
@Matovidlo Matovidlo force-pushed the feat-add-ro-chat-event branch from 98e4ffc to dc29d0f Compare October 16, 2025 09:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new JSON schema for the ext.keboola.ro-chat event and corresponding test fixtures covering several serverTransport variants.

  • Introduces schema/ext.keboola.ro-chat.json defining mcpServerContext, message, and tool structure (with transport enum).
  • Adds four event fixture JSON files exercising presence/absence and different values of serverTransport (http, sse, omitted).

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
schema/ext.keboola.ro-chat.json New schema defining structure and enum for serverTransport and tool arguments.
tests/events/ext.keboola.ro-chat.json Base event fixture with serverTransport http.
tests/events/ext.keboola.ro-chat.http.json Event fixture explicitly for http transport.
tests/events/ext.keboola.ro-chat.sse.json Event fixture for sse transport.
tests/events/ext.keboola.ro-chat.no-transport.json Event fixture omitting serverTransport to validate optionality.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Base automatically changed from bc-remove-old-mcp-schema to main October 17, 2025 12:33
Copy link

@vita-stejskal vita-stejskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@AdamVyborny AdamVyborny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matovidlo Matovidlo merged commit b37762c into main Oct 17, 2025
1 check passed
@Matovidlo Matovidlo deleted the feat-add-ro-chat-event branch October 17, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants