Skip to content

Comments

SUPPORT–11949 fix for broken sync action & traceback in the JSON response#202

Merged
soustruh merged 8 commits intomasterfrom
SUPPORT-11949-broken-sync-action
Jul 2, 2025
Merged

SUPPORT–11949 fix for broken sync action & traceback in the JSON response#202
soustruh merged 8 commits intomasterfrom
SUPPORT-11949-broken-sync-action

Conversation

@soustruh
Copy link
Contributor

all the May commits can be skipped during the review (ruff is just a ruff, ignoring flake8 false positives is self-explanatory, log traceback was removed eventually in favor of the new decorator function

@soustruh soustruh requested review from bornedan, Copilot and kudj June 12, 2025 13:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes broken sync actions by adding an exception handler that captures and returns tracebacks in the JSON response, and applies a broad code-style cleanup across the repository.

  • Added sync_action_exception_handler decorator to wrap all @sync_action methods, catching unhandled exceptions and returning a structured traceback.
  • Standardized all string literals to double quotes and ensured trailing commas in multi-line literals for consistency.
  • Reformatted dict and argument formatting in tests and source files for readability.

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/component.py Added sync_action_exception_handler, applied consistent quoting and trailing commas
tests/ (all test_*.py files) Converted single quotes to double quotes and added trailing commas
src/actions/curl.py Adjusted quoting, added missing trailing commas
src/user_functions.py Standardized quoting and function signatures
flake8.cfg Added ignore = E203,W503

@soustruh soustruh force-pushed the SUPPORT-11949-broken-sync-action branch from f43bab8 to 7632a5d Compare June 12, 2025 13:15
soustruh added 2 commits June 30, 2025 13:51
because gpg --recv-keys returns 0 even when the key is skipped 👀
@soustruh soustruh merged commit f291b05 into master Jul 2, 2025
6 checks passed
@soustruh soustruh deleted the SUPPORT-11949-broken-sync-action branch July 2, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants