SUPPORT–11949 fix for broken sync action & traceback in the JSON response#202
Merged
SUPPORT–11949 fix for broken sync action & traceback in the JSON response#202
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes broken sync actions by adding an exception handler that captures and returns tracebacks in the JSON response, and applies a broad code-style cleanup across the repository.
- Added
sync_action_exception_handlerdecorator to wrap all@sync_actionmethods, catching unhandled exceptions and returning a structured traceback. - Standardized all string literals to double quotes and ensured trailing commas in multi-line literals for consistency.
- Reformatted dict and argument formatting in tests and source files for readability.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/component.py | Added sync_action_exception_handler, applied consistent quoting and trailing commas |
tests/ (all test_*.py files) |
Converted single quotes to double quotes and added trailing commas |
| src/actions/curl.py | Adjusted quoting, added missing trailing commas |
| src/user_functions.py | Standardized quoting and function signatures |
| flake8.cfg | Added ignore = E203,W503 |
f43bab8 to
7632a5d
Compare
bornedan
approved these changes
Jun 12, 2025
…PPORT-11949-broken-sync-action
because gpg --recv-keys returns 0 even when the key is skipped 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all the May commits can be skipped during the review (ruff is just a ruff, ignoring flake8 false positives is self-explanatory, log traceback was removed eventually in favor of the new decorator function