Skip to content

Comments

Support-13110: Fix function evaluation in user parameters#203

Merged
kudj merged 5 commits intomasterfrom
SUPPORT-13110
Sep 10, 2025
Merged

Support-13110: Fix function evaluation in user parameters#203
kudj merged 5 commits intomasterfrom
SUPPORT-13110

Conversation

@kudj
Copy link
Contributor

@kudj kudj commented Sep 9, 2025

No description provided.

@kudj kudj requested review from Copilot and soustruh September 9, 2025 12:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes function evaluation in user parameters by ensuring that functions defined in configuration parameters are properly evaluated before being used in API requests. The changes enable the evaluation of nested functions (like concat) within both request parameters and URL construction.

  • Adds function evaluation to request parameters before building request content
  • Implements function evaluation for URL construction parameters
  • Updates Node.js version in Docker configuration
  • Adds comprehensive test case for parameter function evaluation

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
python-sync-actions/src/configuration.py Adds function evaluation to endpoint parameters before request content building
python-sync-actions/src/component.py Implements function evaluation for URL building parameters and adds null safety
python-sync-actions/tests/calls/011-params-func-eval/ Test files demonstrating function evaluation in parameters
python-sync-actions/tests/calls/010-default-header/config.json Updates authorization header to use function evaluation
Dockerfile Updates Node.js version from v22.10.0 to v22.19.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kudj kudj requested a review from a team September 9, 2025 12:31
Copy link
Contributor

@soustruh soustruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems OK, please just remove the redundant structure from the tests configuration… 😇

}
],
"test": "test-value",
"concat": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally left duplicate object… 🤷‍♂️

@kudj kudj requested a review from soustruh September 10, 2025 11:35
Copy link
Contributor

@soustruh soustruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change 🌞

@kudj kudj requested a review from ujovlado September 10, 2025 11:38
@kudj kudj merged commit 5ab3962 into master Sep 10, 2025
6 checks passed
@kudj kudj deleted the SUPPORT-13110 branch September 10, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants