Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#29 Enable MacOS Line breaks as acceptable #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#29 Enable MacOS Line breaks as acceptable #30

wants to merge 1 commit into from

Conversation

ssmusoke
Copy link

No description provided.

@ssmusoke ssmusoke mentioned this pull request May 15, 2018
Open
@Halama
Copy link
Member

Halama commented May 18, 2018

Hi Stephen,
thanks for contribution. The reason why MacOS line breaks were not enable is that current implementation of CSV read can't handle it. I've extended tests to demonstrate it https://github.com/keboola/php-csv/pull/31/files
https://travis-ci.org/keboola/php-csv/jobs/380590953

But it looks like there is a simple workaround which makes it passing https://travis-ci.org/keboola/php-csv/jobs/380590953
We'll release soon a new major version #27 so I think we can implement this there in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssmusoke @Halama