Merged
Conversation
jirkasemmler
force-pushed
the
jirka/dmd-189-support-keypair
branch
2 times, most recently
from
b143d6f to
4128f41
Compare
jirkasemmler
force-pushed
the
jirka/dmd-189-support-keypair
branch
from
0c2d5fd to
2ad93ac
Compare
jirkasemmler
commented
Jun 30, 2025
| CREATE USER "KEBOOLA_CI_PHP_STORAGE_DRIVER_SNOWFLAKE" | ||
| PASSWORD = 'ewC@B3.6UyWVLxe*MZMdN7xYEnX6ZV_P' | ||
| DEFAULT_ROLE = "KEBOOLA_CI_PHP_STORAGE_DRIVER_SNOWFLAKE"; | ||
| PASSWORD = '' |
Contributor
Author
There was a problem hiding this comment.
nechavam tady password a neresim TYPE, protoze to se odstrani az s https://github.com/keboola/storage-backend/pull/212/files
jirkasemmler
commented
Jun 30, 2025
| protected function getSnowflakeConnection(): Connection | ||
| { | ||
| $this->connection = SnowflakeConnectionFactory::getConnection( | ||
| $this->connection = SnowflakeConnectionFactory::getConnectionWithCert( |
Contributor
Author
There was a problem hiding this comment.
defaultne se k tomu uz chovam jako ke keypairu. BC pro heslo je tady jen docasna, opet odstranena pak v #212
jirkasemmler
commented
Jun 30, 2025
| "Keboola\\StorageDriver\\": "packages/php-storage-driver-common/generated/Keboola/StorageDriver", | ||
| "Keboola\\StorageDriver\\Contract\\": "packages/php-storage-driver-common/contract/", | ||
| "Keboola\\StorageDriver\\Shared\\": "packages/php-storage-driver-common/Shared/", | ||
| "Keboola\\StorageDriver\\Snowflake\\": "packages/php-storage-driver-snowflake/src/", |
Contributor
Author
There was a problem hiding this comment.
protoze to tady chybelo z initu repa
martinsifra
requested changes
Jun 30, 2025
packages/php-storage-driver-snowflake/src/ConnectionFactory.php
Outdated
Show resolved
Hide resolved
martinsifra
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: DMD-189
Connection PR: https://github.com/keboola/connection/pull/6022/files
SAPI PR: -
support private key if the value looks like private key