Skip to content

PATCH php-datatypes 7.10.1 #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zajca wants to merge 2 commits into from
Closed

PATCH php-datatypes 7.10.1 #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1cfada
feat: Increase maximum VARCHAR size in Snowflake to 128MB, according …
pepamartinec Apr 11, 2025
8c65901
feat: Use separate default and max length for Snowflake VARCHAR
pepamartinec Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/php-datatypes/src/Definition/Snowflake.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ class Snowflake extends Common
self::TYPE_GEOMETRY,
self::TYPE_VECTOR,
];
public const MAX_VARCHAR_LENGTH = 16777216;
public const DEFAULT_VARCHAR_LENGTH = 16777216;
public const MAX_VARCHAR_LENGTH = 134217728;
public const MAX_VARBINARY_LENGTH = 8388608;

/**
Expand Down
6 changes: 3 additions & 3 deletions packages/php-datatypes/tests/SnowflakeDatatypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,10 @@ public function testValidCharacterLengths(): void
new Snowflake('STRING');
new Snowflake('STRING', ['length' => '']);
new Snowflake('STRING', ['length' => '1']);
new Snowflake('STRING', ['length' => '16777216']);
new Snowflake('STRING', ['length' => '134217728']);
new Snowflake('STRING', [
'length' => [
'character_maximum' => '16777216',
'character_maximum' => '134217728',
],
]);
new Snowflake('STRING', [
Expand Down Expand Up @@ -444,7 +444,7 @@ public function invalidCharacterLengths(): array
return [
['a'],
['0'],
['16777217'],
['134217729'],
['-1'],
];
}
Expand Down
2 changes: 1 addition & 1 deletion packages/php-db-import-export/src/Backend/Snowflake/ToStage/StageTableDefinitionFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ private static function createNvarcharColumn(string $columnName): SnowflakeColum
new Snowflake(
Snowflake::TYPE_VARCHAR,
[
'length' => (string) Snowflake::MAX_VARCHAR_LENGTH,
'length' => (string) Snowflake::DEFAULT_VARCHAR_LENGTH,
'nullable' => true, // set all columns to be nullable
],
),
Expand Down