Conversation
vojtabiberle
force-pushed
the
vb/supabase/list_buckets
branch
from
5ff15f5 to
b841979
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for listing available database schemas/buckets through a new ListBucketsCommand for Supabase integration. The changes include proto definitions and auto-generated PHP classes to support external bucket registration functionality.
Changes:
- Added
ListBucketsCommandandListBucketsResponsemessages to the info.proto file - Added
management_api_tokenfield toSupabaseCredentialsMetafor OAuth-based Management API access - Generated corresponding PHP classes and metadata files
Reviewed changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/php-storage-driver-common/proto/info.proto | Defines new ListBucketsCommand and ListBucketsResponse messages for retrieving available schemas |
| packages/php-storage-driver-common/proto/credentials.proto | Adds management_api_token field to SupabaseCredentialsMeta for Management API authentication |
| packages/php-storage-driver-common/generated/Keboola/StorageDriver/Credentials/GenericBackendCredentials/SupabaseCredentialsMeta.php | Generated PHP class with getter/setter methods for the new management_api_token field |
| packages/php-storage-driver-common/generated/Keboola/StorageDriver/Command/Info/ListBucketsCommand.php | Generated PHP class for the list buckets command (empty command with no parameters) |
| packages/php-storage-driver-common/generated/Keboola/StorageDriver/Command/Info/ListBucketsResponse.php | Generated PHP class for the list buckets response containing schema names |
| packages/php-storage-driver-common/generated/GPBMetadata/Proto/Info.php | Generated metadata file for info.proto with new command definitions |
| packages/php-storage-driver-common/generated/GPBMetadata/Proto/Credentials.php | Generated metadata file for credentials.proto with updated SupabaseCredentialsMeta |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vojtabiberle
requested review from
a team and
romanbracinik
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://linear.app/keboola/issue/DMD-991/supabase-poc
Connection PR:
SAPI PR:
Release Notes
Impact analysis
Change type
Justification