Open
Conversation
…tly and take informations from definitions
CAST operations were applied unconditionally in SET, comparison WHERE, and PK WHERE clauses — even when destination columns are STRING, which is redundant and breaks existing behavior. Now CAST is only applied when the destination column type differs from STRING (e.g. INT64, FLOAT64). Also adds tests for the typed-destination-column scenario (cross-backend CSV loads where staging is STRING but destination has INT64 columns). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When using STRING_TABLE strategy with convertEmptyValuesToNull, the NULLIF expression returned a STRING which BigQuery rejected when the destination column was typed (e.g. TIMESTAMP). Now wraps NULLIF in CAST to the destination type, matching what getUpdateWithPkCommand already does for incremental loads. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: DMD-849
Connection PR: https://github.com/keboola/connection/pull/6642
Release Notes
Impact analysis
Change type