Skip to content

Comments

DMD-745 add DirectGrantTable to workspace create/drop#272

Merged
zajca merged 1 commit intomainfrom
zajca/dmd-745/bq-dg-om
Feb 19, 2026
Merged

DMD-745 add DirectGrantTable to workspace create/drop#272
zajca merged 1 commit intomainfrom
zajca/dmd-745/bq-dg-om

Conversation

@zajca
Copy link
Member

@zajca zajca commented Feb 19, 2026

Jira: DMD-745
Connection PR: https://github.com/keboola/connection/pull/6674
SAPI PR: -


  • Create tag
  • Create release in read-only repo

Release Notes

  • Add top-level DirectGrantTable protobuf message with repeated string path + string tableName fields
  • Add directGrantTables repeated field to both CreateWorkspaceCommand (field 11) and DropWorkspaceCommand (field 5)

Impact analysis

  • Backward compatible — new message and new repeated fields default to empty, existing consumers are unaffected
  • No runtime impact until driver-bigquery and connection consume the new fields

Change type

  • new feature

Justification

  • BigQuery direct grant output mapping (DMD-745) requires granting table-level IAM bindings when a workspace is created and revoking them when a workspace is deleted. The driver needs to know which tables should have direct grants. These fields pass that information to CreateWorkspaceHandler and DropWorkspaceHandler.
  • DirectGrantTable is a top-level message (not nested) because it is shared between two commands — avoids cross-command type dependency.
  • Uses repeated string path + string tableName pattern consistent with all other table-related commands in the codebase (CreateTableCommand, DropTableCommand, PreviewTableCommand, etc.).

@linear
Copy link

linear bot commented Feb 19, 2026

@zajca zajca marked this pull request as ready for review February 19, 2026 07:18
@zajca zajca requested review from a team and vojtabiberle and removed request for a team February 19, 2026 07:18
@zajca zajca changed the title DMD-748 add DirectGrantTable to workspace create/drop DMD-745 add DirectGrantTable to workspace create/drop Feb 19, 2026
@jirkasemmler
Copy link
Contributor

@zajca prosim drzme zase nejakou navaznost v reviews - RFC jsi chtel checknout od me/Romana, tak si pojdme rict, ze i ty reviews budeme davat na me/Romana. viz https://keboola.atlassian.net/wiki/spaces/ENGG/pages/404815876/KBC+Team+internal+meeting#:~:text=libi%20se%20nam%20to%2C%20konecne%20budou%20pseudo%2Dfeature%20teams

@zajca zajca requested review from jirkasemmler and romanbracinik and removed request for vojtabiberle February 19, 2026 07:21
@zajca zajca force-pushed the zajca/dmd-745/bq-dg-om branch from f69c936 to e210d84 Compare February 19, 2026 09:17
@zajca zajca merged commit 17c8381 into main Feb 19, 2026
51 checks passed
@zajca zajca deleted the zajca/dmd-745/bq-dg-om branch February 19, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants