DMD-745 add DirectGrantTable to workspace create/drop#272
Merged
Conversation
Contributor
|
@zajca prosim drzme zase nejakou navaznost v reviews - RFC jsi chtel checknout od me/Romana, tak si pojdme rict, ze i ty reviews budeme davat na me/Romana. viz https://keboola.atlassian.net/wiki/spaces/ENGG/pages/404815876/KBC+Team+internal+meeting#:~:text=libi%20se%20nam%20to%2C%20konecne%20budou%20pseudo%2Dfeature%20teams |
f69c936 to
e210d84
Compare
jirkasemmler
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: DMD-745
Connection PR: https://github.com/keboola/connection/pull/6674
SAPI PR: -
Release Notes
DirectGrantTableprotobuf message withrepeated string path+string tableNamefieldsdirectGrantTablesrepeated field to bothCreateWorkspaceCommand(field 11) andDropWorkspaceCommand(field 5)Impact analysis
Change type
Justification
CreateWorkspaceHandlerandDropWorkspaceHandler.DirectGrantTableis a top-level message (not nested) because it is shared between two commands — avoids cross-command type dependency.repeated string path+string tableNamepattern consistent with all other table-related commands in the codebase (CreateTableCommand,DropTableCommand,PreviewTableCommand, etc.).