Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add keda default labels to cert-manager objects #724

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: add keda default labels to cert-manager objects #724

merged 1 commit into from
Jan 8, 2025

Conversation

mindw
Copy link
Contributor

@mindw mindw commented Dec 31, 2024

Provide a description of what has been changed

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #

@mindw
add keda default labels to cert-manager objects
3a63743 
Signed-off-by: Gabi Davar <grizzly.nyo@gmail.com>
@mindw mindw requested a review from a team as a code owner December 31, 2024 08:50
@mindw mindw changed the title add keda default labels to cert-manager objects fix: add keda default labels to cert-manager objects Dec 31, 2024
wozniakjan
wozniakjan approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@zroubalik zroubalik merged commit 3e58b2a into kedacore:main Jan 8, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mindw @zroubalik @wozniakjan