Add queueLengthStrategy option to azure-storage-queue scaler. #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tomkerkhove
reviewed
Jun 11, 2024
| @@ -26,6 +27,7 @@ triggers: | |||
|
|
|||
| - `queueName` - Name of the queue. | |||
| - `queueLength` - Target value for queue length passed to the scaler. Example: if one pod can handle 10 messages, set the queue length target to 10. If the actual number of messages in the queue is 30, the scaler scales to 3 pods. (Default: `5`, Optional) | |||
| - `queueLengthStrategy` - `default` considers both visible and invisible messages, while `visibleonly` uses Peek to count only visible messages. In `visibleonly`, if the count of messages is 32 or higher, it falls back to the default strategy, counting both visible and invisible messages. | |||
There was a problem hiding this comment.
Default is not really clarifying what it includes. Instead I would propose to call it all
There was a problem hiding this comment.
Also, please align with the "(Default: 5, Optional)" convention as per https://github.com/kedacore/keda-docs#writing-documentation-for-a-scaler
There was a problem hiding this comment.
Thanks for the feedback. Hope this version is better?
|
Can you fix the DCO issues please? You can learn more in our contribution guide. |
leodip
force-pushed
the
4478-add-queueLengthStrategy
branch
from
ab99319 to
5ffdeb4
Compare
Signed-off-by: Leonardo D'Ippolito <contact@leodip.com>
leodip
force-pushed
the
4478-add-queueLengthStrategy
branch
from
5ffdeb4 to
316d648
Compare
|
DCO fixed. |
tomkerkhove
approved these changes
Jun 17, 2024
zroubalik
approved these changes
Jul 30, 2024
shubhusion
pushed a commit
to shubhusion/keda-docs
that referenced
this pull request
Aug 5, 2024
…re#1406) Signed-off-by: Leonardo D'Ippolito <contact@leodip.com> Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds documentation about the new
queueLengthStrategyconfiguration option for the Azure Storage Queue scaler.Related to kedacore/keda#4478