Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor azure queue scaler #6269

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Refactor azure queue scaler #6269

merged 3 commits into from
Nov 4, 2024

Conversation

rickbrouwer
Copy link
Contributor

@rickbrouwer rickbrouwer commented Oct 24, 2024 •
edited
Loading

Checklist

Related: 5797

@rickbrouwer rickbrouwer requested a review from a team as a code owner October 24, 2024 15:02
@rickbrouwer
Copy link
Contributor Author

Since Microsoft is actually the maintainer of Azure scalers I don't know if this PR is allowed.
I did my best, but a good review is desired!

@rickbrouwer rickbrouwer marked this pull request as draft October 24, 2024 16:00
@rickbrouwer rickbrouwer force-pushed the azure-queue branch 2 times, most recently from 49b2ad7 to a5b72c6 Compare October 25, 2024 07:27
@rickbrouwer
Refactor azure queue scaler
ebb9bf8 
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
@rickbrouwer rickbrouwer marked this pull request as ready for review October 25, 2024 07:57
@wozniakjan
Copy link
Member

Since Microsoft is actually the maintainer of Azure scalers I don't know if this PR is allowed.

It is allowed and also it is much appreciated ❤️
Can I kindly ask you @SpiritZhou to also take a look for any Microsoft-specific requirements?

@wozniakjan
Copy link
Member

wozniakjan commented Oct 25, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@rickbrouwer
Copy link
Contributor Author

Hmm....i see some errors in the azure_event_hub_dapr_wi_test.
Something is going wrong there while deleting the template: helper.go:609: Deleting template: triggerAuthTemplate

@rickbrouwer
update after feedback
cd58a41 
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
@rickbrouwer
Copy link
Contributor Author

Let's wait to run the e2e for this PR until #6271 is merged and this branch is updated

@SpiritZhou
Copy link
Contributor

SpiritZhou commented Oct 31, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented Nov 3, 2024 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) November 3, 2024 10:56
wozniakjan
wozniakjan approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@JorTurFer JorTurFer merged commit 54c315d into kedacore:main Nov 4, 2024
19 checks passed
@rickbrouwer rickbrouwer deleted the azure-queue branch November 4, 2024 11:09
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
@rickbrouwer @JorTurFer @mpechner-akasa
Refactor azure queue scaler (kedacore#6269)
561fc84 
* Refactor azure queue scaler

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

* update after feedback

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

---------

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
@rickbrouwer @JorTurFer @chiragbhatia8
Refactor azure queue scaler (kedacore#6269)
506336b 
* Refactor azure queue scaler

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

* update after feedback

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

---------

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semgrep-app semgrep-app[bot] semgrep-app[bot] left review comments

@wozniakjan wozniakjan wozniakjan approved these changes

@SpiritZhou SpiritZhou SpiritZhou approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickbrouwer @wozniakjan @SpiritZhou @JorTurFer