Fix plugin loading #274
Merged
Fix plugin loading #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the switch to importlib, plugins are retrieved by name, not integer index. For details see importlib.metadata.EntryPoints.__getitem__() Also update the mock.patch to match: entry_points() -> EntryPoints
edwagner
force-pushed
the
fix-plugin-loading
branch
from
b300bfb
to
c659d45
Compare
kedder
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the switch to importlib, plugins are retrieved by name, not integer index.
For details see importlib.metadata.EntryPoints.getitem()
I discovered this when trying to run ofxstatement with my plugin and I got an error like:
I also had to make a tweak to the plugin test to make the mock more in line with importlib.