Skip to content

Commit

Permalink
Fix Lint and Windows build (#1763)
Browse files Browse the repository at this point in the history
* fix lint issue on main

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* update win orb

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* test conda env

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* add install miniconda

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* add install miniconda

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* add install miniconda

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* add install miniconda

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* add install miniconda

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* add install miniconda

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* add install miniconda

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* add install miniconda

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* add install miniconda

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* add install miniconda test1

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* using msft image

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* using msft image

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* remove msft image

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* remove msft image

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* reverting test changes

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

* revert test branch condition

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>

---------

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
  • Loading branch information
ravi-kumar-pilla authored Feb 27, 2024
1 parent 93fe1c8 commit 1d2496d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
11 changes: 6 additions & 5 deletions .circleci/continue_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ parameters:
default: false

orbs:
win: circleci/windows@2.4.1
win: circleci/windows@4.1.1
node: circleci/node@5.0.3

# No windows executor is listed here since windows builds use win/default and modify
Expand Down Expand Up @@ -73,15 +73,16 @@ commands:
make build
win_setup_python_env:
# Miniconda3 is pre-installed on the machine:
# https://circleci.com/docs/2.0/hello-world-windows/
parameters:
python_version:
type: string
steps:
- run:
name: Initialize conda
command: conda init powershell
name: Install and initialize Miniconda
command: |
choco install miniconda3 -y
refreshenv
C:\tools\miniconda3\Scripts\conda init powershell
- run:
name: Create 'kedro-viz' conda environment
command: conda create --name kedro-viz python=<<parameters.python_version>> -y
Expand Down
3 changes: 1 addition & 2 deletions package/kedro_viz/data_access/repositories/graph.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ def __init__(self):
self.edges_list: Set[GraphEdge] = set()

def __iter__(self) -> Generator:
for edge in self.edges_list:
yield edge
yield from self.edges_list

def remove_edge(self, edge: GraphEdge):
"""Remove an edge from this edge repository.
Expand Down

0 comments on commit 1d2496d

Please sign in to comment.