Feature branch/remove experiment tracking #2237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove exp tracking from feature hits and global toolbar; remove ExperimentsIcon Signed-off-by: tynandebold <thdebold@gmail.com> * Remove /experiment-tracking directory; fix tests Signed-off-by: tynandebold <thdebold@gmail.com> * Remove exp. tracking utils, reducers, styles Signed-off-by: tynandebold <thdebold@gmail.com> * Update moto requirement from ~=5.0.9 to ~=5.0.21 in /package (#2218) Updates the requirements on [moto](https://github.com/getmoto/moto) to permit the latest version. - [Release notes](https://github.com/getmoto/moto/releases) - [Changelog](https://github.com/getmoto/moto/blob/master/CHANGELOG.md) - [Commits](getmoto/moto@5.0.9...5.0.21) --- updated-dependencies: - dependency-name: moto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update httpx requirement from ~=0.27.0 to ~=0.28.0 in /package (#2216) Updates the requirements on [httpx](https://github.com/encode/httpx) to permit the latest version. - [Release notes](https://github.com/encode/httpx/releases) - [Changelog](https://github.com/encode/httpx/blob/master/CHANGELOG.md) - [Commits](encode/httpx@0.27.0...0.28.0) --- updated-dependencies: - dependency-name: httpx dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update bandit requirement from ~=1.7 to ~=1.8 in /package (#2215) Updates the requirements on [bandit](https://github.com/PyCQA/bandit) to permit the latest version. - [Release notes](https://github.com/PyCQA/bandit/releases) - [Commits](PyCQA/bandit@1.7.0...1.8.0) --- updated-dependencies: - dependency-name: bandit dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update boto3 requirement from ~=1.34 to ~=1.35 in /package (#2214) Updates the requirements on [boto3](https://github.com/boto/boto3) to permit the latest version. - [Release notes](https://github.com/boto/boto3/releases) - [Commits](boto/boto3@1.34.0...1.35.71) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jitendra Gundaniya <38945204+jitu5@users.noreply.github.com> * Revert change from PR #2179 Signed-off-by: tynandebold <thdebold@gmail.com> * Remove the sanitizedPathname() function Signed-off-by: tynandebold <thdebold@gmail.com> * Remove Cypress tests for exp tracking Signed-off-by: tynandebold <thdebold@gmail.com> * Merge localStorageState state instead of the older allLocalStorageState Signed-off-by: tynandebold <thdebold@gmail.com> --------- Signed-off-by: tynandebold <thdebold@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jitendra Gundaniya <38945204+jitu5@users.noreply.github.com>
…riment-tracking Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
* remove session store Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove relateds tests Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove doc about session store Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * lint formatting Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove session store from tests Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update docs reference Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update test_server Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove sessions store from load_data Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove make_db_session_factory Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove session store from _load_data_helper Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove database.py entirely Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove test graphql folder Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove cy test related to ET tab Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * Revert changes for .md as it will be done separately Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * revert contributing.md Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove e2e test failed from ET Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> --------- Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> Co-authored-by: Huong Nguyen <huong.nguyen@mckinsey.com>
* revert back the getVersion in graphql Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update queries and schema Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * fix lint error Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * revert graphql_router since it's still using in getVersion Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove experiment-tracking.py, and runs and tracking datatset from repos Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * fix lint Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update format lint Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove set_database_session Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> --------- Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> Co-authored-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
* revert back the getVersion in graphql Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update queries and schema Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * fix lint error Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * revert graphql_router since it's still using in getVersion Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove experiment-tracking.py, and runs and tracking datatset from repos Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * fix lint Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update format lint Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove set_database_session Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove ET mentioned in the doc and readme Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * remove ET and session store from readme Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> * update new architecture diagram to remove apollo graphQL Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> --------- Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com> Co-authored-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Huongg
requested review from
rashidakanchwala,
astrojuanlu,
ravi-kumar-pilla and
jitu5
as code owners
|
We have decided to first do a release with a Deprecation Warning for ET and then in the release after that remove ET. Hence we can close this PR for now, and reopen it after the next release. Ofcourse, the branch is most important, so let's make sure it's there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #2202. This PR is to QA the final version of removing ET from kedro-viz, which includes:
To be done: adding a whole TSC here for approval
Checklist
RELEASE.mdfile