Skip to content

Commit

Permalink
Don't use npm update before publication
Browse files Browse the repository at this point in the history
In our projects we use `npm update` to resolve latest versions for
prerelease packages from `@keep-network` scope that the current project
depends on. In case of `sortition-pools` there are no dependencies to any
contracts so we don't need to use `npm update`.

What plain `npm update` did was updating all the packages we defined in
dependencies that could cause problems as we were testing agains
specific versions locked in package-lock and also CI executed it's tests
agains them but here at the very last step before package publication we
updated locked versions. If we need to update contracts dependencies in
prerelease cycle we should specify which packages we want to update,
e.g. `npm update @keep-network/sortition-pools`.
  • Loading branch information
nkuba committed Jan 13, 2021
1 parent 5d77d5f commit e49102f
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,6 @@ jobs:
# Consider including commit id? Would be +<commit id>.
npm version prerelease --preid=$preid --no-git-tag-version
# Fix resolved dependency versions.
npm update
- name: Publish package
run: npm publish --access public
env:
Expand Down

0 comments on commit e49102f

Please sign in to comment.