Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(providers): Added documentation for missing providers #2167

Merged
merged 22 commits into from
Oct 14, 2024

Conversation

rishisulakhe
Copy link
Contributor

@rishisulakhe rishisulakhe commented Oct 11, 2024

[Fixes #2033]
/claim #2033

Closes #2033

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • [X ] I have updated the documentation as required
  • [ X] All the tests have passed

Copy link

vercel bot commented Oct 11, 2024

@rishisulakhe is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2024

CLA assistant check
All committers have signed the CLA.

@rishisulakhe rishisulakhe changed the title Added documentation for missing providers: service now, python, github etc. /claim #2033 Added documentation for missing providers: service now, python, github... Oct 11, 2024
@talboren
Copy link
Member

Please adjust the PR name to follow conventions 🙏🏼 thanks for the contribution!

@talboren talboren changed the title Added documentation for missing providers: service now, python, github... docs(providers): Added documentation for missing providers Oct 13, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this @rishisulakhe! I left a few comments and look forward to merging this into main once you fix them :)

docs/providers/documentation/service-now-provider.mdx Outdated Show resolved Hide resolved
docs/providers/documentation/keep-provider.mdx Outdated Show resolved Hide resolved
docs/providers/documentation/auth0-provider.mdx Outdated Show resolved Hide resolved
@rishisulakhe
Copy link
Contributor Author

Hello, @talboren
I have addressed the feedback and made the necessary changes. Please review the latest updates.

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 9:13am

talboren
talboren previously approved these changes Oct 13, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talboren talboren enabled auto-merge (squash) October 13, 2024 15:04
@talboren
Copy link
Member

@rishisulakhe
Copy link
Contributor Author

Hey, @talboren
I have done with necessary changes. Please review the latest updates.

@Matvey-Kuk
Copy link
Contributor

Looks great! Please fix the minor comment above and I'll merge!

@rishisulakhe
Copy link
Contributor Author

@Matvey-Kuk
Done with all necessary changes.
Thanks

Matvey-Kuk
Matvey-Kuk previously approved these changes Oct 13, 2024
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@Matvey-Kuk Matvey-Kuk enabled auto-merge (squash) October 13, 2024 18:15
@rishisulakhe
Copy link
Contributor Author

@Matvey-Kuk
Fixes the last error

package-lock.json Outdated Show resolved Hide resolved
docs/mint.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
docs/mint.json Outdated Show resolved Hide resolved
Signed-off-by: rishisulakhe <rishiprasadsulakhe@gmail.com>
package-lock.json Outdated Show resolved Hide resolved
Signed-off-by: rishisulakhe <rishiprasadsulakhe@gmail.com>
docs/mint.json Outdated Show resolved Hide resolved
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talboren talboren enabled auto-merge (squash) October 14, 2024 09:11
@talboren talboren merged commit 8a2d747 into keephq:main Oct 14, 2024
7 checks passed
Copy link
Contributor

🚂 Fantastic work @rishisulakhe! Your very first PR to keep has been merged! 🎉🥳

You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌
If you're feeling adventurous, why not dive into another issue and keep contributing? The community would love to see more from you! 🚀

For any support, feel free to reach out to the developer onboarding lead: @talboren. Happy coding! 👩‍💻👨‍💻

@Matvey-Kuk
Copy link
Contributor

/approve

@rishisulakhe
Copy link
Contributor Author

@Matvey-Kuk @talboren
Thanks for helping me.
This was my first PR that has been merged.
Will contribute more to "keep" in future.

@Matvey-Kuk
Copy link
Contributor

Thank you @rishisulakhe !

@rishisulakhe
Copy link
Contributor Author

@Matvey-Kuk How to claim bounty?

@Matvey-Kuk
Copy link
Contributor

@rishisulakhe I talk to the Algora, their bot should popup here with instructions, but it didn't for some reasons.

@Matvey-Kuk
Copy link
Contributor

@rishisulakhe while we're dealing with Algora (I'm not sure if we'll be able to return the bot), may I ask you to enable GitHub Sponsorship for your account? We'll use it to compensate the contribution.

@rishisulakhe
Copy link
Contributor Author

@Matvey-Kuk
I have just enabled Github Sponsored for my account. It is pending for approval.

@rishisulakhe rishisulakhe deleted the docs-provider-issue-2033 branch October 17, 2024 06:04
@rishisulakhe
Copy link
Contributor Author

rishisulakhe commented Oct 28, 2024

@Matvey-Kuk @talboren
My github Sponsers profile is now live at https://github.com/sponsors/rishisulakhe.
Now you can use it to compensate my contribution.
Thanks

@Matvey-Kuk
Copy link
Contributor

@rishisulakhe on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📃 Docs]: Missing documentation for a few providers
4 participants