Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test case for #249 #256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mAAdhaTTah
Copy link
Collaborator

Subscribing to a circular dep should cause everything to
deactivate but doesn't.

I don't have a solution to this yet, but if anyone has ideas why this might be happening, we at least have a test case we can use to verify the solution.

Subscribing to a circular dep should cause everything to
deactivate but doesn't.
@mAAdhaTTah mAAdhaTTah added the bug label Oct 25, 2017
@mAAdhaTTah mAAdhaTTah mentioned this pull request Oct 26, 2017
2 tasks
@rpominov
Copy link
Member

This seems like something impossible to fix without some kind of global supervision that would analyze all observables and detect loops. I mean from the point of view of individual observables there is no way to notice a loop and deactivate itself, i.e. notice that the only subscriber that left is effectively the same observable.

@mAAdhaTTah
Copy link
Collaborator Author

notice that the only subscriber that left is effectively the same observable.

I'd probably have to dig into the internals a bit more, but if the only subscriber isn't active, we don't necessarily need to detect a loop, do we?

@rpominov
Copy link
Member

rpominov commented Oct 26, 2017

but if the only subscriber isn't active

A subscriber isn't an observable it's just a callback. The callback is added by an observable, but we have access only to the callback. But even if we had access to the observable it's in fact active because it also have a subscriber (basically from the first observable, via another intermediate observable).

@bpinto
Copy link
Contributor

bpinto commented Aug 15, 2021

If this isn't a bug, should we consider closing this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants