Merge pull request #63 from keithbrink/analysis-x0y530

Apply fixes from StyleCI
keithbrink · Jan 21, 2022 · 0fd95e4 · 0fd95e4
2 parents ef3a5ed + 6e01104
commit 0fd95e4
Show file tree

Hide file tree

Showing 23 changed files with 120 additions and 120 deletions.
diff --git a/src/AmazonCore.php b/src/AmazonCore.php
@@ -164,7 +164,7 @@ protected function __construct($s, $mock = false, $m = null, $config = null)
             $this->setConfig($config);
         }
 
-        $this->env = __DIR__ . '/environment.php';
+        $this->env = __DIR__.'/environment.php';
         $this->options['SignatureVersion'] = 2;
         $this->options['SignatureMethod'] = 'HmacSHA256';
     }
@@ -255,13 +255,13 @@ protected function fetchMockFile($load = true)
         ) {
             $url = $this->mockFiles[$this->mockIndex];
         } else {
-            $url = __DIR__ . '/../tests/mocks/' . $this->mockFiles[$this->mockIndex];
+            $url = __DIR__.'/../tests/mocks/'.$this->mockFiles[$this->mockIndex];
         }
         $this->mockIndex++;
 
         if (file_exists($url)) {
             try {
-                $this->log('Fetched Mock File: ' . basename($url));
+                $this->log('Fetched Mock File: '.basename($url));
                 if ($load) {
                     $return = simplexml_load_file($url);
                 } else {
@@ -270,7 +270,7 @@ protected function fetchMockFile($load = true)
 
                 return $return;
             } catch (\Exception $e) {
-                $this->log("Error when opening Mock File: $url - " . $e->getMessage(), 'Warning');
+                $this->log("Error when opening Mock File: $url - ".$e->getMessage(), 'Warning');
 
                 return false;
             }
@@ -366,15 +366,15 @@ protected function fetchMockResponse()
 <ErrorResponse xmlns="http://mws.amazonaws.com/doc/2009-01-01/">
   <Error>
     <Type>Sender</Type>
-    <Code>' . $r['error'] . '</Code>
-    <Message>' . $r['answer'] . '</Message>
+    <Code>'.$r['error'].'</Code>
+    <Message>'.$r['answer'].'</Message>
   </Error>
   <RequestID>123</RequestID>
 </ErrorResponse>';
         }
 
         $r['headarray'] = [];
-        $this->log('Returning Mock Response: ' . $r['code']);
+        $this->log('Returning Mock Response: '.$r['code']);
 
         $this->rawResponses[] = $r;
 
@@ -403,7 +403,7 @@ protected function checkResponse($r)
         } else {
             $xml = simplexml_load_string($r['body'])->Error;
             $this->log(
-                'Bad Response! ' . $r['code'] . ' ' . $r['error'] . ': ' . $xml->Code . ' - ' . $xml->Message,
+                'Bad Response! '.$r['code'].' '.$r['error'].': '.$xml->Code.' - '.$xml->Message,
                 'Urgent'
             );
 
@@ -643,12 +643,12 @@ protected function genQuery()
      */
     protected function sendRequest($url, $param)
     {
-        $this->log('Making request to Amazon: ' . $this->options['Action']);
+        $this->log('Making request to Amazon: '.$this->options['Action']);
         $this->throttleCount = 0;
         $response = $this->fetchURL($url, $param);
 
         if (! isset($response['code']) || ! array_key_exists('code', $response)) {
-            $this->log('Unrecognized response: ' . print_r($response, true));
+            $this->log('Unrecognized response: '.print_r($response, true));
 
             return;
         }
@@ -755,7 +755,7 @@ protected function sleep()
     {
         flush();
         $s = ($this->throttleTime == 1) ? '' : 's';
-        $this->log('Request was throttled, Sleeping for ' . $this->throttleTime . " second$s", 'Throttle');
+        $this->log('Request was throttled, Sleeping for '.$this->throttleTime." second$s", 'Throttle');
         sleep($this->throttleTime);
     }
 
@@ -911,7 +911,7 @@ protected function _getParametersAsString(array $parameters)
     {
         $queryParameters = [];
         foreach ($parameters as $key => $value) {
-            $queryParameters[] = $key . '=' . $this->_urlencode($value);
+            $queryParameters[] = $key.'='.$this->_urlencode($value);
         }
 
         return implode('&', $queryParameters);
@@ -950,7 +950,7 @@ protected function _calculateStringToSignV2(array $parameters)
     {
         $data = 'POST';
         $data .= "\n";
-        $endpoint = parse_url($this->urlbase . $this->urlbranch);
+        $endpoint = parse_url($this->urlbase.$this->urlbranch);
         $data .= $endpoint['host'];
         $data .= "\n";
         $uri = array_key_exists('path', $endpoint) ? $endpoint['path'] : null;

diff --git a/src/AmazonFeedList.php b/src/AmazonFeedList.php
@@ -119,7 +119,7 @@ public function setFeedIds($s)
             $this->resetFeedIds();
             $i = 1;
             foreach ($s as $x) {
-                $this->options['FeedSubmissionIdList.Id.' . $i] = $x;
+                $this->options['FeedSubmissionIdList.Id.'.$i] = $x;
                 $i++;
             }
         } else {
@@ -162,7 +162,7 @@ public function setFeedTypes($s)
             $this->resetFeedTypes();
             $i = 1;
             foreach ($s as $x) {
-                $this->options['FeedTypeList.Type.' . $i] = $x;
+                $this->options['FeedTypeList.Type.'.$i] = $x;
                 $i++;
             }
         } else {
@@ -206,7 +206,7 @@ public function setFeedStatuses($s)
             $this->resetFeedStatuses();
             $i = 1;
             foreach ($s as $x) {
-                $this->options['FeedProcessingStatusList.Status.' . $i] = $x;
+                $this->options['FeedProcessingStatusList.Status.'.$i] = $x;
                 $i++;
             }
         } else {
@@ -298,11 +298,11 @@ public function fetchFeedSubmissions($r = true)
     {
         $this->prepareToken();
 
-        $url = $this->urlbase . $this->urlbranch;
+        $url = $this->urlbase.$this->urlbranch;
 
         $query = $this->genQuery();
 
-        $path = $this->options['Action'] . 'Result';
+        $path = $this->options['Action'].'Result';
         if ($this->mockMode) {
             $xml = $this->fetchMockFile()->$path;
         } else {
@@ -411,11 +411,11 @@ public function countFeeds()
     {
         $this->prepareCount();
 
-        $url = $this->urlbase . $this->urlbranch;
+        $url = $this->urlbase.$this->urlbranch;
 
         $query = $this->genQuery();
 
-        $path = $this->options['Action'] . 'Result';
+        $path = $this->options['Action'].'Result';
         if ($this->mockMode) {
             $xml = $this->fetchMockFile()->$path;
         } else {
@@ -470,11 +470,11 @@ public function cancelFeeds()
     {
         $this->prepareCancel();
 
-        $url = $this->urlbase . $this->urlbranch;
+        $url = $this->urlbase.$this->urlbranch;
 
         $query = $this->genQuery();
 
-        $path = $this->options['Action'] . 'Result';
+        $path = $this->options['Action'].'Result';
         if ($this->mockMode) {
             $xml = $this->fetchMockFile()->$path;
         } else {

diff --git a/src/AmazonFinancialGroupList.php b/src/AmazonFinancialGroupList.php
@@ -135,11 +135,11 @@ public function fetchGroupList($r = true)
 
         $this->prepareToken();
 
-        $url = $this->urlbase . $this->urlbranch;
+        $url = $this->urlbase.$this->urlbranch;
 
         $query = $this->genQuery();
 
-        $path = $this->options['Action'] . 'Result';
+        $path = $this->options['Action'].'Result';
 
         if ($this->mockMode) {
             $xml = $this->fetchMockFile()->$path;

diff --git a/src/AmazonFulfillmentOrderList.php b/src/AmazonFulfillmentOrderList.php
@@ -151,11 +151,11 @@ public function fetchOrderList($r = true)
     {
         $this->prepareToken();
 
-        $url = $this->urlbase . $this->urlbranch;
+        $url = $this->urlbase.$this->urlbranch;
 
         $query = $this->genQuery();
 
-        $path = $this->options['Action'] . 'Result';
+        $path = $this->options['Action'].'Result';
 
         if ($this->mockMode) {
             $xml = $this->fetchMockFile()->$path;

diff --git a/src/AmazonInventoryList.php b/src/AmazonInventoryList.php
@@ -130,7 +130,7 @@ public function setSellerSkus($a)
                 $this->resetSkus();
                 $i = 1;
                 foreach ($a as $x) {
-                    $this->options['SellerSkus.member.' . $i] = $x;
+                    $this->options['SellerSkus.member.'.$i] = $x;
                     $i++;
                 }
             } else {
@@ -192,11 +192,11 @@ public function fetchInventoryList($r = true)
         }
         $this->prepareToken();
 
-        $url = $this->urlbase . $this->urlbranch;
+        $url = $this->urlbase.$this->urlbranch;
 
         $query = $this->genQuery();
 
-        $path = $this->options['Action'] . 'Result';
+        $path = $this->options['Action'].'Result';
 
         if ($this->mockMode) {
             $xml = $this->fetchMockFile()->$path;

diff --git a/src/AmazonMerchantServiceList.php b/src/AmazonMerchantServiceList.php
@@ -126,8 +126,8 @@ public function setItems($a)
         $i = 1;
         foreach ($a as $x) {
             if (is_array($x) && isset($x['OrderItemId']) && isset($x['Quantity'])) {
-                $this->options['ShipmentRequestDetails.ItemList.Item.' . $i . '.OrderItemId'] = $x['OrderItemId'];
-                $this->options['ShipmentRequestDetails.ItemList.Item.' . $i . '.Quantity'] = $x['Quantity'];
+                $this->options['ShipmentRequestDetails.ItemList.Item.'.$i.'.OrderItemId'] = $x['OrderItemId'];
+                $this->options['ShipmentRequestDetails.ItemList.Item.'.$i.'.Quantity'] = $x['Quantity'];
                 $i++;
             } else {
                 $this->resetItems();
@@ -376,7 +376,7 @@ public function setMaxArrivalDate($d)
             $this->options['ShipmentRequestDetails.MustArriveByDate'] = $this->genTime($d);
         } catch (Exception $e) {
             unset($this->options['ShipmentRequestDetails.MustArriveByDate']);
-            $this->log('Error: ' . $e->getMessage(), 'Warning');
+            $this->log('Error: '.$e->getMessage(), 'Warning');
 
             return false;
         }
@@ -396,7 +396,7 @@ public function setShipDate($d)
             $this->options['ShipmentRequestDetails.ShipDate'] = $this->genTime($d);
         } catch (Exception $e) {
             unset($this->options['ShipmentRequestDetails.ShipDate']);
-            $this->log('Error: ' . $e->getMessage(), 'Warning');
+            $this->log('Error: '.$e->getMessage(), 'Warning');
 
             return false;
         }
@@ -553,11 +553,11 @@ public function fetchServices()
             return false;
         }
 
-        $url = $this->urlbase . $this->urlbranch;
+        $url = $this->urlbase.$this->urlbranch;
 
         $query = $this->genQuery();
 
-        $path = $this->options['Action'] . 'Result';
+        $path = $this->options['Action'].'Result';
         if ($this->mockMode) {
             $xml = $this->fetchMockFile()->$path;
         } else {

diff --git a/src/AmazonOrderItemList.php b/src/AmazonOrderItemList.php
@@ -138,11 +138,11 @@ public function fetchItems($r = true)
     {
         $this->prepareToken();
 
-        $url = $this->urlbase . $this->urlbranch;
+        $url = $this->urlbase.$this->urlbranch;
 
         $query = $this->genQuery();
 
-        $path = $this->options['Action'] . 'Result';
+        $path = $this->options['Action'].'Result';
         if ($this->mockMode) {
             $xml = $this->fetchMockFile()->$path;
         } else {
@@ -162,7 +162,7 @@ public function fetchItems($r = true)
         } else {
             if (isset($this->options['AmazonOrderId']) && $this->options['AmazonOrderId'] && $this->options['AmazonOrderId'] != $xml->AmazonOrderId) {
                 $this->log(
-                    'You grabbed the wrong Order\'s items! - ' . $this->options['AmazonOrderId'] . ' =/= ' . $xml->AmazonOrderId,
+                    'You grabbed the wrong Order\'s items! - '.$this->options['AmazonOrderId'].' =/= '.$xml->AmazonOrderId,
                     'Urgent'
                 );
             }

diff --git a/src/AmazonOrderList.php b/src/AmazonOrderList.php
@@ -139,7 +139,7 @@ public function setLimits($mode, $lower = null, $upper = null)
                 $after = $this->genTime('- 2 min');
             }
             if ($after > $before) {
-                $after = $this->genTime($upper . ' - 150 sec');
+                $after = $this->genTime($upper.' - 150 sec');
             }
             if ($mode == 'Created') {
                 $this->options['CreatedAfter'] = $after;
@@ -163,7 +163,7 @@ public function setLimits($mode, $lower = null, $upper = null)
                 }
             }
         } catch (\Exception $e) {
-            $this->log('Error: ' . $e->getMessage(), 'Warning');
+            $this->log('Error: '.$e->getMessage(), 'Warning');
 
             return false;
         }
@@ -192,7 +192,7 @@ public function setOrderStatusFilter($list)
                 $this->resetOrderStatusFilter();
                 $i = 1;
                 foreach ($list as $x) {
-                    $this->options['OrderStatus.Status.' . $i] = $x;
+                    $this->options['OrderStatus.Status.'.$i] = $x;
                     $i++;
                 }
             } else {
@@ -258,7 +258,7 @@ public function setPaymentMethodFilter($list)
                 $this->resetPaymentMethodFilter();
                 $i = 1;
                 foreach ($list as $x) {
-                    $this->options['PaymentMethod.' . $i++] = $x;
+                    $this->options['PaymentMethod.'.$i++] = $x;
                 }
             } else {
                 return false;
@@ -383,11 +383,11 @@ public function fetchOrders($r = true)
 
         $this->prepareToken();
 
-        $url = $this->urlbase . $this->urlbranch;
+        $url = $this->urlbase.$this->urlbranch;
 
         $query = $this->genQuery();
 
-        $path = $this->options['Action'] . 'Result';
+        $path = $this->options['Action'].'Result';
         if ($this->mockMode) {
             $xml = $this->fetchMockFile()->$path;
         } else {

diff --git a/src/AmazonOrderSet.php b/src/AmazonOrderSet.php
@@ -92,7 +92,7 @@ public function setOrderIds($o)
                 if (is_array($o)) {
                     $k = 1;
                     foreach ($o as $id) {
-                        $this->options['AmazonOrderId.Id.' . $k] = $id;
+                        $this->options['AmazonOrderId.Id.'.$k] = $id;
                         $k++;
                     }
                 } else {
@@ -136,11 +136,11 @@ public function fetchOrders()
             return false;
         }
 
-        $url = $this->urlbase . $this->urlbranch;
+        $url = $this->urlbase.$this->urlbranch;
 
         $query = $this->genQuery();
 
-        $path = $this->options['Action'] . 'Result';
+        $path = $this->options['Action'].'Result';
         if ($this->mockMode) {
             $xml = $this->fetchMockFile()->$path;
         } else {

diff --git a/src/AmazonPrepInfo.php b/src/AmazonPrepInfo.php
@@ -55,7 +55,7 @@ public function setSkus($s)
             $this->resetSKUs();
             $i = 1;
             foreach ($s as $x) {
-                $this->options['SellerSKUList.Id.' . $i] = $x;
+                $this->options['SellerSKUList.Id.'.$i] = $x;
                 $i++;
             }
         } else {
@@ -120,7 +120,7 @@ public function setAsins($s)
             $this->resetASINs();
             $i = 1;
             foreach ($s as $x) {
-                $this->options['ASINList.Id.' . $i] = $x;
+                $this->options['ASINList.Id.'.$i] = $x;
                 $i++;
             }
         } else {
@@ -173,11 +173,11 @@ public function fetchPrepInstructions()
 
         $this->preparePrep();
 
-        $url = $this->urlbase . $this->urlbranch;
+        $url = $this->urlbase.$this->urlbranch;
 
         $query = $this->genQuery();
 
-        $path = $this->options['Action'] . 'Result';
+        $path = $this->options['Action'].'Result';
         if ($this->mockMode) {
             $xml = $this->fetchMockFile();
         } else {