WNACG | Added support for ".jpeg" and fixed domain update #6101
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AwkwardPeak7
previously approved these changes
Nov 18, 2024
stevenyomi
reviewed
Nov 18, 2024
| @@ -71,7 +71,7 @@ class UpdateUrlInterceptor(private val preferences: SharedPreferences) : Interce | |||
|
|
|||
| val failedResponse = try { | |||
| val response = chain.proceed(request) | |||
| if (response.isSuccessful) return response | |||
| if (response.isSuccessful && response.peekBody(Long.MAX_VALUE).string().contains("紳士漫畫")) return response | |||
There was a problem hiding this comment.
Could there be a cheaper check? What's the URL that returned successful code?
There was a problem hiding this comment.
Doesn't this effectively blocks away all images? Did you test your changes?
There was a problem hiding this comment.
At least check the content-type like this
if (response.header("content-type")?.startsWith("text/html") != true) { return response }
There was a problem hiding this comment.
Please provide the problematic URL so we can decide what's the proper thing to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6050
Closes #6056
Checklist:
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension