filter incomplete synergies in after menu (#659)

keldaanCommunity · May 26, 2023 · 753c7f5 · 753c7f5
1 parent bee2e5e
commit 753c7f5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/app/public/src/pages/component/after/after-menu.css b/app/public/src/pages/component/after/after-menu.css
@@ -53,6 +53,7 @@
 .after-menu .player-team-synergies {
   display: flex;
   align-items: center;
+  padding: 0;
 }
 
 .after-menu .player-team-synergies img:not(:first-of-type) {

diff --git a/app/public/src/pages/component/after/after-menu.tsx b/app/public/src/pages/component/after/after-menu.tsx
@@ -1,13 +1,14 @@
-import React, { useRef } from "react"
+import React from "react"
 import { useAppSelector } from "../../../hooks"
 import Avatar from "../avatar"
 import Team from "./team"
 import { getRankLabel } from "../../../../../../app/types/strings/Strings"
-import "./after-menu.css"
 import SynergyIcon from "../icons/synergy-icon"
 import EloRank from "elo-rank"
 import { ISimplePlayer } from "../../../../../types"
-import { ExpPlace } from "../../../../../types/Config"
+import { ExpPlace, TypeTrigger } from "../../../../../types/Config"
+import { Synergy } from "../../../../../types/enum/Synergy"
+import "./after-menu.css"
 
 function computeElo(players: ISimplePlayer[], player: ISimplePlayer) {
   const eloEngine = new EloRank()
@@ -102,7 +103,7 @@ export default function AfterMenu() {
                   </td>
                   <td>
                     <ul className="player-team-synergies">
-                      {v.synergies.map((s) => (
+                      {v.synergies.filter(isNotIncomplete).map((s) => (
                         <React.Fragment key={s.name}>
                           <SynergyIcon type={s.name} />
                           <span>{s.value}</span>
@@ -119,3 +120,7 @@ export default function AfterMenu() {
     </div>
   )
 }
+
+function isNotIncomplete(s: { name: Synergy, value: number }){
+  return s.value >= TypeTrigger[s.name][0]
+}