Skip to content
This repository was archived by the owner on Sep 6, 2025. It is now read-only.

Full support for WireMock options#7

Open
hprange wants to merge 3 commits intokelveden:masterfrom
hprange:feature/wiremock-configuration-full-support
Open

Full support for WireMock options#7
hprange wants to merge 3 commits intokelveden:masterfrom
hprange:feature/wiremock-configuration-full-support

Conversation

@hprange
Copy link

@hprange hprange commented Dec 2, 2021

Developers can configure the WireMock Java library in many ways to fulfill their testing requirements. The clj-wiremock wrapper, in contrast, only allows the HTTP port to be configured. This pull request adds support for all WireMock options (as of version 2.27.2).

A few considerations about this change:

  • It's one of my first projects using Clojure. Please, let me know if there's a more idiomatic or straightforward way to implement it. I'll gladly amend the pull request.
  • I haven't tested custom certificate options because it requires valid certificates. If you think it's worth it, I can create fake certificates, add them to a test-resource folder and write the test cases.

@hprange hprange force-pushed the feature/wiremock-configuration-full-support branch from 115ceaa to da44323 Compare August 5, 2022 18:57
@hprange
Copy link
Author

hprange commented Aug 5, 2022

@kelveden any comments on this pull request? Any chance to get it merged? Do you want me to make modifications before you accept it? We use Wiremock extensively in our company, and it would be great to change options in a more idiomatic way. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant