Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination test with inline fragment #908

Merged
merged 3 commits into from
Aug 18, 2020

Conversation

bojanserafimov
Copy link
Collaborator

@bojanserafimov bojanserafimov commented Aug 18, 2020

Test for #897

Currently fails. Expect it to pass after #898

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #908 into main will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
+ Coverage   94.88%   95.02%   +0.14%     
==========================================
  Files         109      109              
  Lines        8654     8679      +25     
==========================================
+ Hits         8211     8247      +36     
+ Misses        443      432      -11     
Impacted Files Coverage Δ
graphql_compiler/cost_estimation/analysis.py 99.04% <0.00%> (-0.01%) ⬇️
graphql_compiler/schema/schema_info.py 89.58% <0.00%> (ø)
graphql_compiler/compiler/validation.py 100.00% <0.00%> (ø)
...l_compiler/query_pagination/parameter_generator.py 100.00% <0.00%> (ø)
...ql_compiler/schema_transformation/rename_schema.py 99.47% <0.00%> (+<0.01%) ⬆️
...schema_generation/orientdb/schema_graph_builder.py 95.87% <0.00%> (+0.02%) ⬆️
graphql_compiler/schema_transformation/utils.py 95.45% <0.00%> (+0.03%) ⬆️
...r/schema_generation/sqlalchemy/edge_descriptors.py 98.24% <0.00%> (+0.16%) ⬆️
graphql_compiler/global_utils.py 98.24% <0.00%> (+0.68%) ⬆️
graphql_compiler/compiler/subclass.py 94.11% <0.00%> (+0.78%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2a426...2eb033e. Read the comment docs.

@bojanserafimov bojanserafimov marked this pull request as ready for review August 18, 2020 14:34
@obi1kenobi obi1kenobi merged commit c0b6ddb into main Aug 18, 2020
@obi1kenobi obi1kenobi deleted the add_fragment_pagination_test branch August 18, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants