Skip to content

Conversation

AzhaanGlitch
Copy link

@AzhaanGlitch AzhaanGlitch commented Sep 15, 2025

InstallReminder Component UI Bug Fix

Overview

This project addresses a UI bug in the InstallReminder component where the heading and paragraph text remained dark in dark mode, causing readability issues against the dark background.

Changes Made

  • Removed Inline Styles: Eliminated all inline styles from the InstallReminder.js component to ensure theme adaptability.
  • Introduced CSS Classes: Replaced inline styles with two new CSS classes:
    • install-reminder-container
    • install-reminder-button
  • Updated Stylesheet: Added styling for the new classes to the global custom.css stylesheet.
  • Dark Mode Support: Implemented a [data-theme='dark'] rule to adjust the component's background and text colors for dark mode, ensuring proper visibility.

Issue Resolution

This pull request resolves issue keploy/keploy#2986

Type of Change

  • Bug fix (non-breaking change that fixes an issue).

Testing

The changes were tested by:

  • Running npm run build and npm run serve locally.
  • Verifying that the InstallReminder component renders correctly in both light and dark themes.
  • Confirming that text color inverts appropriately when toggling themes.

Screenshots

  • Light Mode:
Screenshot 2025-09-16 034947 - **Dark Mode (Fixed)**: Screenshot 2025-09-16 034958

Checklist

  • Code adheres to the project's style guidelines.
  • Performed a self-review of the code.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@AzhaanGlitch
Copy link
Author

@Achanandhi-M, I've resolved the dark mode styling issue in the Keploy Installation component. Could you please review the changes? Thanks!
For your ease - keploy/keploy#2986

Copy link
Contributor

@Achanandhi-M Achanandhi-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AzhaanGlitch thanks for raising the PR, can you please change colour in the dark mode it is not really good

@AzhaanGlitch
Copy link
Author

Hey @AzhaanGlitch thanks for raising the PR, can you please change colour in the dark mode it is not really good

Yaa sure, I will make it look more catchy.

@AzhaanGlitch
Copy link
Author

Hello @Achanandhi-M, thank you for your feedback on the PR. I have made the necessary color adjustments for dark mode as requested. Please review the changes and let me know if there are any further modifications needed.

@Achanandhi-M
Copy link
Contributor

Hey @AzhaanGlitch, I’ve reviewed your PR. The design currently looks a bit too dark, and I think it could be improved further. Could you please adjust it to make it look even better?

@AzhaanGlitch
Copy link
Author

AzhaanGlitch commented Sep 16, 2025

Hello @Achanandhi-M, thank you for your feedback on the PR. I have made the necessary color adjustments for dark mode as requested. Please review the changes.

Here is the changed glance -
image

Signed-off-by: Azhaan Ali Siddiqui <azhaanalisiddiqui15@gmail.com>
Signed-off-by: Azhaan Ali Siddiqui <azhaanalisiddiqui15@gmail.com>
Signed-off-by: Azhaan Ali Siddiqui <azhaanalisiddiqui15@gmail.com>
Signed-off-by: Azhaan Ali Siddiqui <azhaanalisiddiqui15@gmail.com>
Copy link
Contributor

@Achanandhi-M Achanandhi-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AzhaanGlitch,
I don’t think any changes are needed in the custom.css file to fix the issue with the dark installation component. Could you please explain why those changes were made in custom.css?

@AzhaanGlitch
Copy link
Author

Hi @Achanandhi-M ,
The changes were necessary to fix critical CSS conflicts that were breaking the dark theme functionality. There were duplicate color variable declarations and conflicting CSS rules that prevented the installation component from displaying properly in dark mode. These weren't optional improvements, they were essential fixes to resolve syntax errors and ensure the component works correctly across both light and dark themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants