Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 955 #50

Closed
wants to merge 9 commits into from
Closed

Issue 955 #50

wants to merge 9 commits into from

Conversation

Bhanuteja01
Copy link

@Bhanuteja01 Bhanuteja01 commented Oct 16, 2023

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # 955

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@Bhanuteja01
Copy link
Author

I have little confusion about version changing.
Can you explain about version changing

@Sarthak160
Copy link
Member

Please Update the README.md as well !!

@Sarthak160
Copy link
Member

Also Have you did mvn clean install , locally ?? As build is failing !!

@Bhanuteja01
Copy link
Author

@Sarthak160 Changes i did is correct??

@Sarthak160
Copy link
Member

Sarthak160 commented Oct 16, 2023

@Sarthak160 Changes i did is correct??

Remove the keploy-sdk from pom instead of commenting and also remove the already created testcases from the src/test folder.

@Bhanuteja01
Copy link
Author

@Sarthak160 should i delete entire SamplesJavaApplication_Test.java file

@Sarthak160
Copy link
Member

@Sarthak160 should i delete entire SamplesJavaApplication_Test.java file

Yes , you can remove the JunitTestFile for now .

Copy link
Author

@Bhanuteja01 Bhanuteja01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have doubt in update readme

@Sarthak160
Copy link
Member

I have doubt in update readme

Whats your doubt ??

@Bhanuteja01
Copy link
Author

how to change the readme file

@Sonichigo
Copy link
Member

The issue attached to this PR has been resolved

@Sonichigo Sonichigo closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants