docs: Updated petclinic README #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
nehagup
reviewed
Feb 9, 2024
spring-petclinic/README.md
Outdated
| @@ -32,21 +20,29 @@ npm i | |||
| ``` | |||
| npm run start | |||
| ``` | |||
|
|
|||
| # Instructions For Starting Using Binary | |||
|
|
|||
| ## Spin up the database | |||
There was a problem hiding this comment.
Need to mention that user need to cd to rest app.
spring-petclinic/README.md
Outdated
| - [Using Keploy's binary](#binary-guide) | ||
| - [Using Keploy's docker image](#docker-guide) | ||
|
|
||
| But first, you need to install Keploy. For that you can use the command below: |
There was a problem hiding this comment.
No one reads "but first" move the keploy instructions above 2 ways.
nehagup
reviewed
Feb 9, 2024
| 1. Node 20.11.0 LTS | ||
| 2. OpenJDK 17.0.9 | ||
| 3. MVN version 3.6.3 | ||
|
|
||
| ## Setup the backend | ||
|
|
||
| ``` |
There was a problem hiding this comment.
cd samples-java/spring-petclinic/spring-petclinic-rest would be required in both docker and bin case, move it to common.
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
PranshuSrivastava
force-pushed
the
README-update
branch
from
35cce08
to
4a0908e
Compare
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
nehagup
approved these changes
Feb 13, 2024
jaiakash
pushed a commit
to jaiakash/samples-java
that referenced
this pull request
Jul 24, 2024
* updated petclinic README Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com> * docs: updated Petclinic README Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com> * docs: made changes according to comments Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com> * docs: removed redundant section Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com> * docs: added \n Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com> * docs: made changes according to the comments Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com> --------- Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com> Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Updated README according to the requested changes
Type of change
Please delete options that are not relevant.
Checklist: