Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keploy Integration - Added sample Java application using JWT Token #76

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Keploy Integration - Added sample Java application using JWT Token #76

wants to merge 9 commits into from

Conversation

jaiakash
Copy link

Pull Request Template

Description

Hi me (@jaiakash) and @amitpanwar789 have worked on the sample Java application with JWT token creation and verification. This sample helps to use the Keploy to test in JAVA.

Fixes keploy/keploy#2016

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

@jaiakash
Copy link
Author

Please review @Swpn0neel @charankamarapu

@jaiakash jaiakash mentioned this pull request Jul 26, 2024
Closed
15 tasks
@charankamarapu
Copy link
Member

I have tried running the application without keploy. On the second request which is mentioned in the README is giving me this error

Screenshot 2024-07-26 at 1 20 33 PM

It is better to keep the token in header than request body (a standard practice).

@jaiakash
Copy link
Author

Hi @charankamarapu Thanks for your suggestion. Have updated the PR to have token in header instead of body.
Also as I can see from screenshots, end point is users/tokenVerification not users/verify

charankamarapu
charankamarapu requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments

spring-boot-jwt/README.md Outdated Show resolved Hide resolved
spring-boot-jwt/README.md Outdated Show resolved Hide resolved
spring-boot-jwt/README.md Show resolved Hide resolved
spring-boot-jwt/README.md Outdated Show resolved Hide resolved
spring-boot-jwt/README.md Show resolved Hide resolved
charankamarapu
charankamarapu reviewed Jul 27, 2024
View reviewed changes
Copy link
Member

@charankamarapu charankamarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments and before requesting for a review please follow the read me and add the record and test screenshots for native and docker case.

spring-boot-jwt/README.md Outdated Show resolved Hide resolved
spring-boot-jwt/README.md
- Login

```bash
curl --location --request POST 'http://localhost:8080/users/login' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the native case removed ..?

These should be the headings

Prerequisites
Getting Started
Native Usage
Docker Usage

  • here only you can write the command to build application image etc.

we dont need API Endpoints/ Running with Docker section

spring-boot-jwt/keploy.yml Show resolved Hide resolved
spring-boot-jwt/README.md Outdated Show resolved Hide resolved
@jaiakash jaiakash mentioned this pull request Aug 1, 2024
Open
1 task
@jaiakash
Copy link
Author

jaiakash commented Aug 5, 2024

Hi @yaten2302, did you check it?

@yaten2302
Copy link

Apologies for the delay, @jaiakash. I've DM you on Slack.

jaiakash and others added 8 commits September 10, 2024 03:15
@jaiakash
git: to new branch
6d7f1ca 
Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
@jaiakash
fix: readme file and token in header instead of body
65407cf 
Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
@jaiakash
docs: update the docs for header
c73adcd 
Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
@jaiakash
fix: jwt verfication, add: error mssg, docs:docker instllation
7f71580 
Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
@jaiakash
docs: docker optional and mvn clean
e3afa9d 
Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
@PranshuSrivastava @jaiakash
feat: update employee manager (keploy#77)
1f224fc 
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
@Hermione2408 @jaiakash
feat: add spring-mysql-redis to samples java (keploy#78)
3aaa63e 
* feat:Add spring-mysql-redis to samples java

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

* remove .idea and target folder

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

* add .idea and target to gitignore

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

* add .idea and target to gitignore

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

* remove reports from .gitignore

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>

---------

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
@jaiakash
fix: readme steps
fd2af46 
Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
@jaiakash
Copy link
Author

jaiakash commented Sep 9, 2024

Hi @PranshuSrivastava @Sonichigo @charankamarapu, I am incredibly sorry for the delay.

Have updated the PR. Can you please suggest what changes are required in this readme file or maybe the overall project?

Thanks

cc @yaten2302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charankamarapu charankamarapu Awaiting requested review from charankamarapu

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature]: Creating Sample Java Application using JWT Token
5 participants
@jaiakash @charankamarapu @yaten2302 @PranshuSrivastava @Hermione2408