yml file updated #52
Open
yml file updated #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey @ananyab1909, Thank you for raising the pr! Our team will into soon before that make sure to sign the DCO signoff
| app: | ||
| container_name: fastapi-app | ||
| image: fastapi | ||
| image: keploy/fastapi-app:latest |
There was a problem hiding this comment.
I don't think it will be great, as there is no image name keploy/fastapi-app
| networks: | ||
| - keploy-network | ||
|
|
||
| volumes: |
There was a problem hiding this comment.
Have you tried it running on your local machine?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It improves the fastapi-postgres sample by adding a Postgres health check, a persistent volume, proper Docker image naming, and internal network setup.