-
Notifications
You must be signed in to change notification settings - Fork 300
update preset map for ViT model #2418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
update preset map for ViT model #2418
Conversation
Summary of ChangesHello @sonali-kumari1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the naming conventions for Vision Transformer (ViT) model presets. By updating the keys in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the preset names for the ViT model in the checkpoint conversion script to align with the official naming convention. While the changes for ImageNet-1k presets are correct, there is a critical inconsistency in the naming of ImageNet-21k presets. The script uses a double underscore (e.g., __imagenet21k
) while the official preset definitions use a single underscore. This will lead to incorrectly named presets. I've provided a suggestion to fix this.
Thanks for the PR, are all the models with the corrected name are loading properly both Keras and HF models? |
@sachinprasadhs, Few HF models are failing to load due to |
This PR updates
PRESET_MAP
for ViT model to align with the official naming convention used in Keras and Kaggle documentation.