-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Add daily Python 3.13 CPU-only tests to nightly workflow #21566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21566 +/- ##
==========================================
- Coverage 82.73% 82.59% -0.15%
==========================================
Files 567 572 +5
Lines 56678 58535 +1857
Branches 8839 9158 +319
==========================================
+ Hits 46895 48345 +1450
- Misses 7609 7853 +244
- Partials 2174 2337 +163
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! (and sorry for the delay in the review)
.github/workflows/nightly.yml
Outdated
python-version: ["3.10"] | ||
backend: [tensorflow, jax, torch, numpy] | ||
name: Run tests | ||
name: Run tests (Python 3.10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work if you put ${{ matrix.python-version }}
here?
The goal is to minimize the number of things to change when we upgrade Python.
.github/workflows/nightly.yml
Outdated
matrix: | ||
python-version: ["3.13"] | ||
backend: [tensorflow, jax, torch, numpy] | ||
name: Run tests (Python 3.13) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it work if you put ${{ matrix.python-version }}
here?
The goal is to minimize the number of things to change when we upgrade Python.
.github/workflows/nightly.yml
Outdated
KERAS_BACKEND: ${{ matrix.backend }} | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Set up Python 3.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove "3.13" here.
The goal is to minimize the number of things to change when we upgrade Python.
@hertschuh Thanks for the review, I updated the code to use |
Thanks for adding this, @rohithpudari ! |
fixes #21508
Adds
build-python-latest
job in Nightly pipeline