Llm empty response fix #423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to allow better conversations
Seems to be happening with DeepSeek v3 implementation form Together.ai
…m-empty-response-fix
…a/wire-pod into llm-empty-response-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently wirepod crashes if the LLM returns an empty content as part of its streaming responses.
For some providers/ models that seems to be a common occuring.
This fix prevents wirepod from crashing. Without this fix, wirepod will crash with:
Bot 00902161 Transcribed text: what is two plus three
Not a custom intent
Making LLM request for device 00902161...
Using deepseek-ai/DeepSeek-V3
Using remembered chats, length of 0 messages
LLM stream response:
Hmm, let me think about that!
Bot 00902161 Intent Sent: intent_greeting_hello
No Parameters Sent
{{playAnimationWI||thinking}} Hmm, let me think...
panic: runtime error: index out of range [0] with length 0
goroutine 147 [running]:
github.com/kercre123/wire-pod/chipper/pkg/wirepod/ttr.StreamingKGSim.func2()
/mnt/ssddrive/alldata/code/wire-pod/chipper/pkg/wirepod/ttr/kgsim.go:348 +0xe10
created by github.com/kercre123/wire-pod/chipper/pkg/wirepod/ttr.StreamingKGSim in goroutine 26
/mnt/ssddrive/alldata/code/wire-pod/chipper/pkg/wirepod/ttr/kgsim.go:294 +0x10b8