Windows support via Mingw64 PyGObject#105
Open
horiac7 wants to merge 1 commit intokeredson:masterfrom
Open
Conversation
horiac7
force-pushed
the
winbranch-new
branch
from
d52bde5 to
4494b6b
Compare
horiac7
force-pushed
the
winbranch-new
branch
from
4494b6b to
c1807fc
Compare
Contributor
Author
|
Rebased the source on the target upstream master. |
…n Windows. * Add support for Windows-specific utilities for detecting if ffmpeg is installed etc. * Adapted bottle file serving to support windows paths by providing a folderpath and filename. * Removed filtering of FileChooserDialog - this does not seem to work on Windows * Better handling of temporary files: use tempfile.NamedTemporaryFile instead of tempfile.mkstemp * Update README.md with instructions on setting up MSYS2 and PyGObject to run on Windows - along with other environment setup needed.
horiac7
force-pushed
the
winbranch-new
branch
from
c1807fc to
e78231f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I closed my previous PR #80 for Windows support and added another one, since the previous one was quite old and outdated in relation to the master branch.
In the mean-time I have found another way of runing GTK and PyGObject on Windows and that is through MSYS2. I wrote an extensive guide on that in README.md under "Running on Windows"
I can still see some issues in that for the videos I tested with, there are some left-over temporary files - two are created instead of one, when transcoding occurs. I don't know whether this is a general issue or it occurs only because of my changes - maybe you can check and confirm.
By the way, if you don't have a Windows machine available, check out the following link for getting a Win 10 dev VM available in different formats, which would allow testing my code:
https://developer.microsoft.com/en-us/windows/downloads/virtual-machines