Skip to content

Fix unable to close / exit the application until the application "init" phase finishes #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kami wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix unable to close / exit the application until the application "init" phase finishes #112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44672be
Fix check ffmpeg thread and init casts threads blocking the main GUI
Kami Jan 24, 2020
ec30ace
No need to return the thread since we went with a very simple daemon
Kami Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gnomecast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ def __init__(self):
def run(self, fn=None, device=None, subtitles=None):
self.build_gui()
self.init_casts(device=device)
threading.Thread(target=self.check_ffmpeg).start()
threading.Thread(target=self.check_ffmpeg, daemon=True).start()
t = threading.Thread(target=self.start_server)
t.daemon = True
t.start()
Expand Down Expand Up @@ -522,7 +522,7 @@ def init_casts(self, widget=None, device=None):
self.cast_store.clear()
self.cast_store.append([None, "Searching local network - please wait..."])
self.cast_combo.set_active(0)
threading.Thread(target=self.load_casts, kwargs={'device':device}).start()
threading.Thread(target=self.load_casts, daemon=True, kwargs={'device':device}).start()

def inhibit_screensaver(self):
if not self.saver_interface or self.inhibit_screensaver_cookie: return
Expand Down