Questions: Build General Structure

components/ILIAS/Administration/GlobalScreen/classes/AdministrationMainBarProvider.php

@@ -225,7 +225,7 @@ private function getGroups(): array
         // admin menu layout
         $layout = array(
             "maintenance" =>
-                array("adma", "serv", "cron", "bnmk", "lngf", "hlps", "wfe", 'fils', 'logs', 'sysc', "recf", "root"),
+                array("adma", "serv", "cron", "bnmk", "lngf", "hlps", "wfe", 'fils', 'qsts', 'logs', 'sysc', "recf", "root"),
             "layout_and_navigation" =>
                 array("mme", "gsfo", "dshs", "stys", "adve", "stus"),
             "repository_and_objects" =>

components/ILIAS/AdministrativeNotification/classes/Table.php

@@ -68,7 +68,7 @@ public function __construct(
 
         $this->components[] = $this->ui_factory->table()->data(
             $data_retrieval,
-            $this->lng->txt('notifications'),
+            $this->lng->txt('msg_table_title'),
             $columns,
         )->withActions($actions)->withRequest(
             $DIC->http()->request()

components/ILIAS/AuthShibboleth/classes/Config/class.ilShibbolethSettings.php

@@ -34,7 +34,7 @@ class ilShibbolethSettings
     /**
      * @var string
      */
-    private const DEFAULT_LOGIN_BUTTON = "assets/images/auth/shib_login_button.svg";
+    private const DEFAULT_LOGIN_BUTTON = "./assets/images/auth/shib_login_button.svg";
     /**
      * @var string
      */

components/ILIAS/AuthShibboleth/classes/Config/class.shibConfig.php

@@ -457,9 +457,6 @@ public function setUpdateTitle(bool $update_title): void
         $this->update_title = $update_title;
     }
 
-    /**
-     * @return mixed
-     */
     public function getUpdateTitle(): bool
     {
         return $this->update_title;

components/ILIAS/AuthShibboleth/classes/class.ilAuthProviderShibboleth.php

@@ -110,7 +110,7 @@ public function doAuthentication(ilAuthStatus $status): bool
             return false;
         }
 
-        ilSession::set('shibboleth_session_id', $_SERVER['Shib-Session-ID']);
+        ilSession::set('shibboleth_session_id', $_SERVER['Shib-Session-ID'] ?? '');
         return true;
     }
 }

components/ILIAS/AuthShibboleth/resources/shib_logout.php

@@ -144,14 +144,15 @@ function LogoutNotification($SessionID): ?\SoapFault
 
     while ($session = $r->fetchRow(ilDBConstants::FETCHMODE_ASSOC)) {
         $session_data = unserializesession($session['data']);
-        if (is_array($session_data)
+        // Delete this session entry
+        if (
+            is_array($session_data)
             && array_key_exists('shibboleth_session_id', $session_data)
-            && $session_data['shibboleth_session_id'] == $SessionID
+            && $session_data['shibboleth_session_id'] === $SessionID
+            && !ilSession::_destroy($session['session_id']
+            )
         ) {
-            // Delete this session entry
-            if (ilSession::_destroy($session['session_id']) !== true) {
-                return new SoapFault('LogoutError', 'Could not delete session entry in database.');
-            }
+            return new SoapFault('LogoutError', 'Could not delete session entry in database.');
         }
     }
     // If no SoapFault is returned, all is fine

components/ILIAS/AuthShibboleth/src/LoginPerformer.php

@@ -75,12 +75,12 @@ public function doShibbolethAuthentication(): void
 
                 // no break
             case ilAuthStatus::STATUS_ACCOUNT_MIGRATION_REQUIRED:
-                $this->ctrl->redirect($this, 'showAccountMigration');
+                $this->ctrl->redirectByClass([ilStartUpGUI::class], 'showAccountMigration');
 
                 // no break
             case ilAuthStatus::STATUS_AUTHENTICATION_FAILED:
                 $this->template->setOnScreenMessage('failure', $status->getTranslatedReason(), true);
-                $this->ctrl->redirect($this, 'showLoginPage');
+                $this->ctrl->redirectByClass([ilStartUpGUI::class], 'showLoginPage');
         }
 
         $this->template->setOnScreenMessage('failure', $this->lng->txt('err_wrong_login'), true);

components/ILIAS/Authentication/classes/Cron/class.ilAuthDestroyExpiredSessionsCron.php

@@ -87,7 +87,7 @@ public function run(): JobResult
         $result->setStatus(JobResult::STATUS_OK);
 
         $num_destroyed_sessions = ilSession::_destroyExpiredSessions();
-        ilSessionStatistics::aggretateRaw(time());
+        ilSessionStatistics::aggregateRaw(time());
         $result->setMessage('Number of destroyed sessions: ' . $num_destroyed_sessions);
 
         return $result;

components/ILIAS/Authentication/classes/class.ilSession.php

@@ -195,7 +195,7 @@ public static function _writeData(string $a_session_id, string $a_data): bool
             if ($r->getInt(0, 50) === 2) {
                 // get time _before_ destroying expired sessions
                 self::_destroyExpiredSessions();
-                ilSessionStatistics::aggretateRaw($now);
+                ilSessionStatistics::aggregateRaw($now);
             }
         }