build: Always pass architecture to actions #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a previous push, I forgot to run `black` on a file I modified. Thje linter has been unhappy since... Fix this. Signed-off-by: Manu Bretelle <chantr4@gmail.com>
In preparation of cross-compiling, ensure that we always pass arch parameter to the action. At a later stage, this parameter will be made required on libbpf-ci. Signed-off-by: Manu Bretelle <chantr4@gmail.com>
|
https://github.com/kernel-patches/vmtest/actions/runs/7879475334/job/21499804418?pr=261#step:11:4 shows that we get a warning for the new parameter, but other than that, libbpf/ci happily ignore the parameter. |
chantra
added a commit
to chantra/kernel-patches-vmtest
that referenced
this pull request
Feb 13, 2024
We will use this to find out whether or not to install cross-compilation toolchain. Similar to kernel-patches#261 Signed-off-by: Manu Bretelle <chantr4@gmail.com>
chantra
added a commit
that referenced
this pull request
Feb 13, 2024
We will use this to find out whether or not to install cross-compilation toolchain. Similar to #261 Signed-off-by: Manu Bretelle <chantr4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of cross-compiling, ensure that we always pass arch parameter to the action.
At a later stage, this parameter will be made required on libbpf-ci.