Fix routes and services offset with kong 1.0.x #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secat
force-pushed
the
fix-routes-and-services-offset-with-kong-1.0.x
branch
2 times, most recently
from
8c7a726 to
72273e2
Compare
…ng 1.0.x and fix passing the query parameter Signed-off-by: scatudal <serge.catudal@gmail.com>
secat
force-pushed
the
fix-routes-and-services-offset-with-kong-1.0.x
branch
from
72273e2 to
2720ecf
Compare
|
@kevholditch this PR is ready for review. Thank you. |
…data inside the for loop to prevent pointer reuse
secat
force-pushed
the
fix-routes-and-services-offset-with-kong-1.0.x
branch
from
0029b99 to
9458fbd
Compare
|
I have fixed the merge conflicts and merged in, thanks for the contribution |
|
Thank you! |
|
@kevholditch the fix seems not to be in the master branch... I have fix the merge conflicts. |
|
@secat sorry I think sorted the other one, can you open this PR again and I'll merge it |
|
@kevholditch I have open a new PR #59 with the fix and resolved merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39