more info in pc template & cmake compatibility #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le with autotools
nilsnolde
commented
Jan 13, 2024
| "${CMAKE_CURRENT_SOURCE_DIR}/libprime_server.pc.in" | ||
| "${CMAKE_CURRENT_BINARY_DIR}/libprime_server.pc" | ||
| # pkg-config stuff, also make it compatible with autotools | ||
| set(prefix ${CMAKE_INSTALL_PREFIX}) |
There was a problem hiding this comment.
the paths weren't set up in a cmake installation
nilsnolde
commented
Jan 29, 2024
Comment on lines
+145
to
+146
| configure_file(cmake/uninstall.cmake.in ${CMAKE_CURRENT_BINARY_DIR}/prime_server_uninstall.cmake @ONLY) | ||
| add_custom_target(uninstall COMMAND ${CMAKE_COMMAND} -P ${CMAKE_CURRENT_BINARY_DIR}/prime_server_uninstall.cmake) |
There was a problem hiding this comment.
same as in the valhalla PR valhalla/valhalla#4516
kevinkreiser
approved these changes
Jun 12, 2024
Co-authored-by: Kevin Kreiser <kevinkreiser@gmail.com>
|
ill have to fix the stupid mac build separately.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to valhalla/valhalla#4507