reuse decompressor to reduce memory consumption #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -331,6 +339,8 @@ public void close() throws IOException { | |||
| decompressor.decompress(b, 0, b.length); | |||
| } | |||
| super.close(); | |||
| if(reuseDecompressor) | |||
There was a problem hiding this comment.
should be done after 'verifyChecksum'. (in a finally clause, to be safe).
|
+1. thanks Yu. |
| @@ -86,7 +87,11 @@ public CompressionInputStream createInputStream(InputStream in, | |||
|
|
|||
| @Override | |||
| public CompressionInputStream createInputStream(InputStream in) throws IOException { | |||
| return createInputStream(in, createDecompressor()); | |||
| /* create a decompressor and tell LzoInputStream to reuse it | |||
| * (return it to the pool when LzoInputStream is closed. | |||
simplify decompressor reuse (reuse decompressors for both cases)
| @@ -111,6 +112,9 @@ public void close() throws IOException { | |||
| } | |||
| closed = true; | |||
| } | |||
| //return the compressor to the pool for later reuse; | |||
| //the returnCompressor handles nulls. | |||
| CodecPool.returnCompressor(compressor); | |||
There was a problem hiding this comment.
for correctness, this should be inside 'if (!closed)' check.
|
+1. thanks for multiple iterations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently we create a new decompressor for each lzo RecordReader. Each lzo decompressor currently uses 0.5MB memory(two 256K buffers) and we can run out of memory when we create many lzo record readers.