Update elastic_output.py #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I cleaned up a bit from the last pull request. The elasticsearch class has an option for disabling the warnings also so I used that instead of making the ssl_context and adding the extra imports. https://elasticsearch-py.readthedocs.io/en/v7.14.1/api.html#elasticsearch.Elasticsearch added the message if ssl_show_warning and verify_certs is false. ``` "elastic_ssl": true, "verify_certs": false, "ssl_show_warn": true, "ca_certs": "/path/to/custom_CA.cer", ```
openssl s_client -connect host:port -showcerts | openssl x509 -noout -fingerprint -md5 if you want to add a self signed fingerprint
fix : should check for is not None
fixing the fix need more coffee
updated message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cleaned up a bit from the last pull request.
The elasticsearch class has an option for disabling the warnings also so I used that instead of making the ssl_context and adding the extra imports.
https://elasticsearch-py.readthedocs.io/en/v7.14.1/api.html#elasticsearch.Elasticsearch
added the message if ssl_show_warning and verify_certs is false.