Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about add a telegram output channel? #56

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

imfht
Copy link

@imfht imfht commented Dec 27, 2018

No description provided.

@kevthehermit
Copy link
Owner

Will get this tested this weekend when i can setup a telegram bot thanks

@Plazmaz
Copy link
Collaborator

Plazmaz commented Sep 21, 2019

@imfht looks like you've got some merge conflicts. If you could rebase off master, we can get this merged in, and that'd be great.

@imfht
Copy link
Author

imfht commented Sep 22, 2019

@Plazmaz Okay I'll do it!

Copy link
Collaborator

@Plazmaz Plazmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you've resolved the conflicts here but it looks like you've added quite a few new dependencies, many of which add vulnerabilities. You should double check that:
A. You need all of the dependencies added (it seems like python-telegram-bot might be the only one used)
B. The dependencies added are up to date.

@imfht
Copy link
Author

imfht commented Oct 12, 2019

Sorry to too last reply
how about now?

@Plazmaz
Copy link
Collaborator

Plazmaz commented Oct 13, 2019

Looks like snyk is still complaining. I don't think I have access to snyk, @kevthehermit do you know what requirements it's having issues with specifically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants