Skip to content

[WIP] Solve issue #110#114

Open
apausa wants to merge 71 commits intokey4hep:mainfrom
apausa:solve-issue-110
Open

[WIP] Solve issue #110#114
apausa wants to merge 71 commits intokey4hep:mainfrom
apausa:solve-issue-110

Conversation

@apausa
Copy link
Collaborator

@apausa apausa commented Mar 16, 2026

BEGINRELEASENOTES

  • Refactor filtering logic by modifying 'front-end' properties instead of creating an additional data structure.
  • Remove event listeners from previous views to avoid overlapping renders
  • Remove conflicting manual viewport culling logic
  • Make a constants/ folder in lib/, moving and creating the necessary variables.
  • Make a utils/ folder in lib/, moving and creating the necessary functions.
  • Create a ui/ folder to handle all DOM related logic:
    • Create load-file.js to isolate JSON file handling logic.
    • Create event-switcher.js to isolate all event selection logic.
    • Create view-selector.js to isolate all view selection logic.
    • Create start-visualization.js to isolate "visualize" button click responsibilities.
    • Create activate-view.js to unify view renders across the whole app.
    • Move the modals/ folder within ui/
      • Refactor information.js modal to only handle visibility responsibilities
      • Refactor input.js modal to only handle visibility responsibilities
      • Refactor welcome.js modal to only handle visibility responsibilities
    • Move the toggle/ folder within ui/
    • Move the filters/ folder within ui/
      • Remove the reconnect/ subfolder as it no longer needed
      • Remove the filter-out.js, reconnect.js and relations.js files as they are no longer needed
      • Remove the collections/ subfolder, integrating all filters definitions in definitions.js
      • Update filter.js to dynamically create filters based on the definitions.
  • Remove current-file.js from state/
  • Move load-event.js from state/ to loaders/
  • Create pixi-state in state/, integrating its logic and caching textures
  • Removed unused sessionStorage calls from globals.js in state/
  • Rename load.js to handleSchema.js in loaders/
  • Move schema loaders to schemas/ subfolder in loaders/, fixing code to handle all schemas
  • Move the views/ folder within viz/
    • Create buildStructures/ subfolder with initial views/ folder files and rename content accordingly
    • Rename templates/ subfolder to positionItems/ and rename content accordingly
    • Create layoutFunction.js to map buildStructures/ code
    • Create selectorFunctions.js to map positionItems/ code
    • Create positionFunctions.js to group initial viewport position logic.
    • Refactor viewsDictionary to link those layout, selector and position functions.
  • Add error information when server address is undefined
  • Bump up version number

ENDRELEASENOTES

@apausa apausa self-assigned this Mar 16, 2026
@github-actions
Copy link

github-actions bot commented Mar 16, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://key4hep.github.io/eede/pr-preview/pr-114/

Built to branch gh-pages at 2026-03-23 14:22 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant