Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FCCeeMDI] Use absolute path to import CAD files #372

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

BrieucF
Copy link
Contributor

@BrieucF BrieucF commented Aug 8, 2024

BEGINRELEASENOTES

  • [FCCeeMDI] Use absolute path to import CAD files

ENDRELEASENOTES

It looks like, when importing CAD file with <shape type="CAD_MultiVolume" ref="path_to_stl_file" unit="mm" material="LiquidNDecane">, the path is relative to where the ddsim command is launched

@andresailer
Copy link
Contributor

andresailer commented Aug 9, 2024

This should work AIDASoft/DD4hep#1175 with recent enough DD4hep versions?

1.27 and newer
https://github.com/AIDASoft/DD4hep/blob/master/doc/ReleaseNotes.md#v01-27

@BrieucF
Copy link
Contributor Author

BrieucF commented Aug 13, 2024

I have opened an issue in DD4hep (AIDASoft/DD4hep#1313). Can we merge this regardless of the issue? I'd keep it like this even after the fix.

@andresailer
Copy link
Contributor

I think this rather is an issue for key4hep-spack though. Because it comes down to ROOT with pcre2 (I think), which we have no control over in DD4hep.

@BrieucF
Copy link
Contributor Author

BrieucF commented Aug 14, 2024

I see. Does this prevent merging this PR?

@andresailer
Copy link
Contributor

Apart from the full path making it harder to changing the files and trying things out with ones own copy of a folder. No, nothing prevents merging these changes.

@andresailer
Copy link
Contributor

andresailer commented Aug 14, 2024

By the way

It looks like, when importing CAD file with , the path is relative to where the ddsim command is launched

Is this your interpretation of the TPRegexp error mentioned in the DD4hep issue, or was this a different error message that caused the conclusion written here?

@BrieucF
Copy link
Contributor Author

BrieucF commented Aug 14, 2024

Is this your interpretation of the TPRegexp error mentioned in the DD4hep issue, or was this a different error message that caused the conclusion written here?

No no, it comes from the fact that running examples/DDCAD/compact/Check_Shape_RelativePath.xml from the DD4hep directory does not work, while going to examples/DDCAD/compact/ and running it from there works, as I tried to explain in AIDASoft/DD4hep#1313. The mention of the TPRegexp error was just a side note that it is not easy to understand that the problem is "not finding the CAD file" based on the error message.

@andresailer
Copy link
Contributor

It does not work in the way that there is the TPRegex error?

@BrieucF
Copy link
Contributor Author

BrieucF commented Aug 14, 2024

Yes

@andresailer andresailer merged commit 0367262 into key4hep:main Aug 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants