-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for pandora PFA #419
Changes for pandora PFA #419
Conversation
…and simple cylinder geometry with both endcaps in same volume
…ra calibration code crashes for hits with zero int/rad lengths
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v03_geo.cpp
Outdated
Show resolved
Hide resolved
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v04_geo.cpp
Outdated
Show resolved
Hide resolved
detector/calorimeter/ECalBarrel_NobleLiquid_InclinedTrapezoids_o1_v04_geo.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! I have left some in-line comments, mainly regarding rhetorical questions and FIXME comments. Addressing these would help improve the overall clarity and maintainability of the code. Let me know your thoughts, and feel free to reach out if you’d like to discuss anything further, for instance, regarding the multisegmentation feature
Hello @atolosadelgado thanks for your review! |
Hello @atolosadelgado |
Thanks for the refactoring of the generic cylinder. Before merging, may I ask if it is needed to update the Readme files? |
I updated the ALLEGRO readme to mention the change in segmentation for the muon tagger in v03 and v04 |
@giovannimarchiori shall we merge? |
Yes please! |
Started from Archi's code in https://github.com/Archil-AD/k4geo/tree/pandora, with some modifications for SimpleCylinder v02 to make it more general
BEGINRELEASENOTES
ENDRELEASENOTES
Tagging @BrieucF - let's look at the code (there are definitely at least a couple of things to be changed quickly, and for some others like the cell sizes for caloData we can think/see how to properly retrieve them from the segmentation and retrieve them. Will mark the PR as draft meanwhile