Add ROSA Benchmark Key Results #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahus1
force-pushed
the
is-432-rosa-key-results
branch
from
effa6be
to
5016312
Compare
|
@mhajas - I've added more context and some more disclaimers. I'd hope this is now ready to be merged. I'd be happy if you could find the time to review it. Thanks! |
mhajas
reviewed
Jul 24, 2023
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
| task dataset-import -- -a create-clients -c 100000 -n realm-0 | ||
| ---- | ||
| . Create load runners | ||
| + |
There was a problem hiding this comment.
Should we mention env.yml is necessary for creating load runners? We can link the docs.
There was a problem hiding this comment.
added in next commit.
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
ahus1
force-pushed
the
is-432-rosa-key-results
branch
2 times, most recently
from
706c51a
to
0255a4f
Compare
Closes keycloak#432 Co-authored-by: Michal Hajas <mhajas@redhat.com>
ahus1
force-pushed
the
is-432-rosa-key-results
branch
from
0255a4f
to
64cf500
Compare
|
@mhajas - ready for a (final?) review. If it is ok now, please merge. Thanks! |
mhajas
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #432