-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROSA Benchmark Key Results #433
Conversation
effa6be
to
5016312
Compare
@mhajas - I've added more context and some more disclaimers. I'd hope this is now ready to be merged. I'd be happy if you could find the time to review it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ahus1. I added a few suggestions.
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
task dataset-import -- -a create-clients -c 100000 -n realm-0 | ||
---- | ||
. Create load runners | ||
+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention env.yml
is necessary for creating load runners? We can link the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in next commit.
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
doc/benchmark/modules/ROOT/pages/report/rosa-benchmark-key-results.adoc
Outdated
Show resolved
Hide resolved
706c51a
to
0255a4f
Compare
Closes keycloak#432 Co-authored-by: Michal Hajas <mhajas@redhat.com>
0255a4f
to
64cf500
Compare
@mhajas - ready for a (final?) review. If it is ok now, please merge. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @ahus1!
Closes #432