Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding FD_SOCK2 -> FD_SOCK workaround #440

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

ahus1
Copy link
Contributor

@ahus1 ahus1 commented Jul 21, 2023

Closes #439

@ahus1 ahus1 self-assigned this Jul 21, 2023
@ahus1 ahus1 marked this pull request as ready for review July 21, 2023 12:38
@ryanemerson ryanemerson self-requested a review July 21, 2023 14:54
@ryanemerson
Copy link
Contributor

LGTM. I don't have sufficient permissions to merge though.

@kami619
Copy link
Contributor

kami619 commented Jul 21, 2023

@ryanemerson were you able to give it a local test ? I can merge the PR if it worked for you.

@ryanemerson
Copy link
Contributor

I did and the cluster formed as expected. I just double checked the logs though and ISPN000901 is still present, so hold off merging and I will investigate if this workaround for 21830 works on a standalone Infinispan instance.

@ahus1
Copy link
Contributor Author

ahus1 commented Jul 21, 2023

@ryanemerson - I debugged it and found that in DNS_PING the correct query hostname is present. I assume this happens when it evalues the parent stack.

If you want to enable debugging, add the following to the Keycloak CR:

  additionalOptions:
    - name: log-level
      value: "INFO,org.jgroups:debug"

@ryanemerson
Copy link
Contributor

ryanemerson commented Jul 24, 2023

I debugged it and found that in DNS_PING the correct query hostname is present. I assume this happens when it evalues the parent stack.

We're still getting the ISPN000901 warning because the Infinispan parser is processing both the "kubernetes" and the "kubernetes-with-fdsock" stacks. We could workaround this by extending the "tcp" stack instead, but as it's just a warning I don't think it's worth the hassle. I think we should remove DNS_PING from the "kubernetes-with-fdsock" stack as it's not removing the warning. We can then just wait on the actual fix in the Keycloak operator, as this doesn't affect functionality.

The FD_SOCK changes LGTM.

@mhajas
Copy link
Contributor

mhajas commented Jul 24, 2023

This PR is trying to address an issue with state transfer, is the issue caused by a different problem than: keycloak/keycloak#21256

@ryanemerson
Copy link
Contributor

This PR is trying to address an issue with state transfer, is the issue caused by a different problem than: keycloak/keycloak#21256

Yes, this fixes an issue with FD_SOCK2 at the JGroups level keycloak/keycloak#21092

@ahus1 ahus1 force-pushed the is-439-add-fdsock-2-workaround branch from 38ccd03 to f4dc7b7 Compare July 24, 2023 11:58
@ahus1 ahus1 merged commit 4d82ffd into keycloak:main Jul 24, 2023
1 check passed
@ahus1
Copy link
Contributor Author

ahus1 commented Jul 24, 2023

Merged as of @ryanemerson's review.

@ahus1 ahus1 deleted the is-439-add-fdsock-2-workaround branch July 31, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests Infinispan tests with FDSOCK instead of FD_SOCK2
4 participants